Re: [linux-minidisc] changed himdformat.c to work on linux and windows

[Michael Karcher <Michael.Karcher@fu-berlin.de>]

Am Freitag, den 09.04.2010, 20:11 +0200 schrieb manner.moe@gmx.de:
> device can be opened. If formatDialog has finished (successful or not) the 
> device is closed and a format_finished() signal is sent.
> The mainwindow sends himd_idle signal then. 
> If formatDialog is shown, Connect button and himd_devices combobox will be 
> disabled to prevent changing the device while format is in progress.
As transferring MD data while formatting is impossible, why don't we
just make the format dialog modal? This would eliminate the need of the
format_finished signal, the disabling of the combobox and maybe other
functions that might interfere with formatting.

> If the device has been removed without using "safely remove hardware" 
> function the formatdialog closes immediately.
Nice.

Regards,
  Michael Karcher

PS: I put this into a post-scriptum so that you don't get the impression
I'm trying to push this work on you to get your patch accepted: Which
each patch I start feeling more that we should make the himddevice
structure a smarter object that has signals/slots on its own. So that
(if we decide against making it modal) we don't need to send the idle
signal via the main window and the detection object, but just send it to
the himddevice object. Also the device deletion would be a signal of the
device object then.
What do you think?

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil