Re: [linux-minidisc] [commit] Linux utilities to deal with Sony Minidisc Walkman branch, master, updated. 0.1.0-9-g763a17a

[manner.moe@gmx.de]

>Betreff : [linux-minidisc] [commit] Linux utilities to deal with Sony Minidisc Walkman branch, master, updated. 0.1.0-9-g763a17a
>Gesendet: 10.04.2011 18:25:18
>An : "linux-minidisc@lists.fu-berlin.de"
>Von: "Michael Karcher <linux-minidisc@lists.fu-berlin.de>"

>----- Originale Nachricht -----
>This is an automated email from the git hooks/post-receive script. It was
>generated because a ref change was pushed to the repository containing
>the project "Linux utilities to deal with Sony Minidisc Walkman".

>The branch, master has been updated
>       via  763a17ae4f0bf9f51c3668744fcb62a49bb74ec2 (commit)

>Those revisions listed above that are new to this repository have
>not appeared on any other notification email; so we list those
>revisions in full, below.

>- Log -----------------------------------------------------------------
>commit 763a17ae4f0bf9f51c3668744fcb62a49bb74ec2
>Author: Michael Karcher <karcher@physik.fu-berlin.de>
>Date:   Sun Apr 10 17:59:34 2011 +0200

>    Fix string handling
>    
>    - Use the linked free list instead of assuming a sufficient number of
>    consecutive string slots to be free
>    
>    - Handle out-of-string space more gracefully
>    
>    - Remove misleading comments in get_songinfo
>    
>    This patch is partly using ideas and code from a proposed by by Thomas Arp.

Hello Michael,
gconvert has following syntax:
gchar * g_convert (const gchar *str, gssize len, const gchar *to_codeset, 
const gchar *from_codeset, gsize *bytes_read, gsize *bytes_written, GError 
**error);
"to_codeset" and "from_codeset" have to be changed.
I think your patch tries to convert utf8 into a valid himd encoding format.

My previous patch uses "length = strlen(string)" inside himd_add_string() and 
doesn´t need the string length as an argument of himd_add_string(). Your 
current patch uses "gsize length" uninitialized. Compilation fails with error 
"too many arguments to function "himd_add_string".
 
If I understand your patch correctly your patch depends on strings encoded in 
utf8. This is true for strings taken from get_songinfo() in himddump.c which 
reads the strings from the id3 tag and converts them to utf8 automatically.
But for future use (titling etc.) we should leave himd_add_string() encoding 
independent, so strings taken from user input shouldn´t be converted if the 
user computers current encoding is a valid encoding format for the himd 
medium.
For example, if the user computers encoding is SHIFT_JIS we shouldn´t convert 
it to utf8 and the try to reconvert it to make himd_add_string work.

Regards
Thomas