Re: [linux-minidisc] "netmdcli send" does not break on errors
On Sep 16, 2011, at 11:31 PM, Thomas Arp wrote:
> I temporarily edited the output messages to check which commands causes errors.
> Downloading to a write protected disc looks like this:
>
> F:\minidisc\linux-minidisc\netmdcli\debug>netmdcli send LP2.wav
> Net MD/Hi-MD
> Sony MZ-RH1
> Raw title: PEARL JAM ALIVE
> Disc Title: PEARL JAM ALIVE
>
> netmd_secure_leave_session: No error
> netmd_secure_set_track_protection: No error
(…)
I think it's in general a good idea to append the name of the command to the error
message. Furthermore, we can add an option to control the verbosity of
netmdcli, so that by default it doesn't display error information if everything
runs fine.
However, before we make any bigger changes to netmdcli/libnetmd, the
code will need some further cleanup first. There is some code in netmdcli
which I think should rather go into libnetmd. I was particularly thinking
about the code which sets up the secure session and sends a track
to the device. That should probably better go into libnetmd, so we
avoid reinventing the wheel over and over again when using libnetmd
in other applications.
We could then also discuss Thomas' other patch which outputs
the NetMD device information in the console messages.
Adrian
