From manner.moe@gmx.de Wed Dec 05 17:24:26 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TgHlp-001QLA-MY>; Wed, 05 Dec 2012 17:24:25 +0100 Received: from mailout-de.gmx.net ([213.165.64.22]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with smtp (envelope-from ) id <1TgHlp-000rqN-Io>; Wed, 05 Dec 2012 17:24:25 +0100 Received: (qmail 29466 invoked by uid 0); 5 Dec 2012 16:24:24 -0000 Received: from 77.6.96.79 by www020.gmx.net with HTTP; Wed, 05 Dec 2012 17:24:22 +0100 (CET) Content-Type: text/plain; charset="utf-8" Date: Wed, 05 Dec 2012 17:24:22 +0100 From: "Thomas Arp" Message-ID: <20121205162422.280930@gmx.net> MIME-Version: 1.0 To: linux-minidisc@lists.fu-berlin.de X-Authenticated: #17747474 X-Flags: 0001 X-Mailer: WWW-Mail 6100 (Global Message Exchange) X-Priority: 3 X-Provags-ID: V01U2FsdGVkX1/TR/xPDa/TkyW4JrO4FX75MR2XSjDeQLyTiKZGKP ew10TH3DxuF8hhXPmflVW1h0HoNOTC/8SMyg== Content-Transfer-Encoding: 8bit X-GMX-UID: YRDNcNkMeSEqb3OtZXUhlH5+IGRvb0B0 X-Originating-IP: 213.165.64.22 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1354724665-00000B1F-19274053/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Checker-Version: SpamAssassin 3.3.2 on Algerien.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: [linux-minidisc] implementing netmd support in the gui application X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 16:24:26 -0000 Hi, i start working on the implementation of the the netmd protocol in our qhimdtransfer gui application. If anyone else is still working on it, has any questions or suggestions, wants to help or anything else, please contact me. It doesn´t make sense if many people are doing the same work independently of each other. Thomas From bardolobo@gmail.com Wed Dec 05 22:36:20 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TgMdf-002CGw-Ia>; Wed, 05 Dec 2012 22:36:19 +0100 Received: from mail-ob0-f182.google.com ([209.85.214.182]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TgMdf-001Tgk-Cr>; Wed, 05 Dec 2012 22:36:19 +0100 Received: by mail-ob0-f182.google.com with SMTP id 16so7116329obc.13 for ; Wed, 05 Dec 2012 13:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:in-reply-to:mime-version:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=49evSd1d0/bzaSMtKeIExu/3b2lYwVYnqH00+W2fCw8=; b=DUVipyTljHT5q6oi9L3vW0INIuGjdyJb2geA0tX27x0C/UGql8bqsHtslNUc2kK+Iv g9FuhgGg6sjO5CRHyEVH50gXB828ujrG6KaVd9qdh9dibqAelAXI0vtKh81rBDq+fdvW JZ7Q14zQyv8otGB2xC0pbVijvXodtdz1LjrMphykJVMRdyjW4P8F1HQTOWOSdKnaOfdm cXUZRncZxTdlauiGFGVt7e3oc5j8dOtFFWN7Bv9Zu7LFfv2aV6EvORAIYSoRm25X9BSd 7+g0ejA4bWyPg/MRiT9CNHAlT7QmgmdTGYb5vqzac2h7s8LdAlQLeyI7BFRc4m6x0yPg HFJg== Received: by 10.60.10.133 with SMTP id i5mr14581459oeb.24.1354743377222; Wed, 05 Dec 2012 13:36:17 -0800 (PST) References: <20121205162422.280930@gmx.net> From: =?ISO-8859-1?Q?M=E1ximo_Chicano_D=EDaz?= In-Reply-To: <20121205162422.280930@gmx.net> Mime-Version: 1.0 (1.0) Date: Wed, 5 Dec 2012 22:36:09 +0100 Message-ID: <68017810383728760@unknownmsgid> To: Thomas Arp Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Originating-IP: 209.85.214.182 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1354743379-00000B1F-4E186972/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID X-Spam-Checker-Version: SpamAssassin 3.3.2 on Botsuana.ZEDAT.FU-Berlin.DE X-Spam-Level: X-Mailman-Approved-At: Wed, 05 Dec 2012 23:18:14 +0100 Cc: "linux-minidisc@lists.fu-berlin.de" Subject: Re: [linux-minidisc] implementing netmd support in the gui application X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 21:36:20 -0000 Hi Thomas, I would like to collaborate, but I don't know anything about programming :S Maybe I could do tests with my md-units? And I have a couple of questions. When you do this implementation, will we be able to transfer atrac songs to Md? And, if so, will be able to make trackmarks?I mean, I can do them in any track I record, but not in one I transfer using sonicstage, and I don't know if this is a limitation in hardware or just on sonicstage. Well, if I can do anything, just say it. TaliesinTaliesinbardwolf. "Un palmo de buen acero iguala al m=E1s alto noble con el m=E1s humilde sie= rvo". El 05/12/2012, a las 17:24, Thomas Arp escribi=F3: > Hi, > i start working on the implementation of the the netmd protocol in our qh= imdtransfer gui application. > If anyone else is still working on it, has any questions or suggestions, = wants to help or anything else, please contact me. > It doesn=B4t make sense if many people are doing the same work independen= tly of each other. > > Thomas > > _______________________________________________ > linux-minidisc mailing list > linux-minidisc@lists.fu-berlin.de > https://lists.fu-berlin.de/listinfo/linux-minidisc From manner.moe@gmx.de Wed Dec 05 23:36:28 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TgNZr-002GMH-Br>; Wed, 05 Dec 2012 23:36:27 +0100 Received: from mailout-de.gmx.net ([213.165.64.23]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with smtp (envelope-from ) id <1TgNZr-001ZP8-9Q>; Wed, 05 Dec 2012 23:36:27 +0100 Received: (qmail invoked by alias); 05 Dec 2012 22:36:25 -0000 Received: from dslc-082-083-136-166.pools.arcor-ip.net (EHLO [192.168.2.100]) [82.83.136.166] by mail.gmx.net (mp069) with SMTP; 05 Dec 2012 23:36:25 +0100 X-Authenticated: #17747474 X-Provags-ID: V01U2FsdGVkX18BwI9CHMoB6HNZfABocp1Fa7okP5I+6EUk91nyaj ZXY1rCVeToBYtt Message-ID: <50BFCC2C.1070809@gmx.de> Date: Wed, 05 Dec 2012 23:35:24 +0100 From: Thomas Arp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: =?ISO-8859-1?Q?M=E1ximo_Chicano_D=EDaz?= References: <20121205162422.280930@gmx.net> <68017810383728760@unknownmsgid> In-Reply-To: <68017810383728760@unknownmsgid> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Y-GMX-Trusted: 0 X-Originating-IP: 213.165.64.23 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1354746987-00000B1F-00C4561A/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Checker-Version: SpamAssassin 3.3.2 on Botsuana.ZEDAT.FU-Berlin.DE X-Spam-Level: Cc: "linux-minidisc@lists.fu-berlin.de" Subject: Re: [linux-minidisc] implementing netmd support in the gui application X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 22:36:28 -0000 Am 05.12.2012 22:36, schrieb Máximo Chicano Díaz: > Hi Thomas, Hi Máximo > I would like to collaborate, but I don't know anything about > programming :S Maybe I could do tests with my md-units? People who wants to test our software and give response how it works are welcome to our community. > And I have a couple of questions. When you do this implementation, I think this will take some weeks, it is a lot of work and needs a lot of rearrangement in our source code. All changes we make have to be tested before they will be committed to the main repository. All i will do ist to implement the already tested transfer routines from our command line tool netmdcli. So, please test our command line tool first. If it doesn't support what you expect the changes to our gui application will not support it, too. > will we be able to transfer atrac songs to Md? At this time only .wav files are supported for transferring to the md unit, atrac files have to be converted first. This is a hardware limitation of minidisc devices, the md unit itself encodes them to atrac format, but this is the same transferring method sonicstage uses. I think Michael can give more information. > And, if so, will be > able to make trackmarks?I mean, I can do them in any track I record, > but not in one I transfer using sonicstage, and I don't know if this > is a limitation in hardware or just on sonicstage. I think this is a limitation of the DRM system in Sony's atrac format. Tracks transferred via sonicstage are copyright protected. So, editing these tracks are not allowed. If you convert them into .wav format first, and then using our software for transferring them to the md unit, it should be able to set trackmarks then. I didn't test this, if you want to do these tests, do them and please give response to us if it works or not. . > > Well, if I can do anything, just say it. > > TaliesinTaliesinbardwolf. > > "Un palmo de buen acero iguala al más alto noble con el más humilde siervo". > > El 05/12/2012, a las 17:24, Thomas Arp escribió: > >> Hi, >> i start working on the implementation of the the netmd protocol in our qhimdtransfer gui application. >> If anyone else is still working on it, has any questions or suggestions, wants to help or anything else, please contact me. >> It doesn´t make sense if many people are doing the same work independently of each other. >> >> Thomas >> >> _______________________________________________ >> linux-minidisc mailing list >> linux-minidisc@lists.fu-berlin.de >> https://lists.fu-berlin.de/listinfo/linux-minidisc From glaubitz@physik.fu-berlin.de Fri Dec 07 21:10:23 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Th4Fa-0028LC-Kc>; Fri, 07 Dec 2012 21:10:22 +0100 Received: from mx.physik.fu-berlin.de ([160.45.64.218]) by relay1.zedat.fu-berlin.de (Exim 4.69) with esmtp (envelope-from ) id <1Th4Fa-002pwy-Ih>; Fri, 07 Dec 2012 21:10:22 +0100 Received: from zlogin.physik.fu-berlin.de ([160.45.66.4]) by mx.physik.fu-berlin.de with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Th4FX-0005Su-DG; Fri, 07 Dec 2012 21:10:19 +0100 Received: from glaubitz by zlogin.physik.fu-berlin.de with local (Exim 4.72 #1 (Debian)) id 1Th4FX-0004M5-C0; Fri, 07 Dec 2012 21:10:19 +0100 Date: Fri, 7 Dec 2012 21:10:19 +0100 From: John Paul Adrian Glaubitz To: Thomas Arp Message-ID: <20121207201019.GA16699@physik.fu-berlin.de> References: <20121205162422.280930@gmx.net> <68017810383728760@unknownmsgid> <50BFCC2C.1070809@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50BFCC2C.1070809@gmx.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: John Paul Adrian Glaubitz X-Originating-IP: 160.45.64.218 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1354911022-00000B1F-AB392115/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000910, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Burundi.ZEDAT.FU-Berlin.DE X-Spam-Level: Cc: =?iso-8859-1?Q?M=E1ximo_Chicano_D=EDaz?= , "linux-minidisc@lists.fu-berlin.de" Subject: Re: [linux-minidisc] implementing netmd support in the gui application X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2012 20:10:23 -0000 Hello Thomas, On Wed, Dec 05, 2012 at 11:35:24PM +0100, Thomas Arp wrote: > >will we be able to transfer atrac songs to Md? > At this time only .wav files are supported for transferring to the > md unit, atrac files have to be converted first. > This is a hardware limitation of minidisc devices, the md unit > itself encodes them to atrac format, but this is the same > transferring method sonicstage uses. > I think Michael can give more information. This isn't actually correct. We can transfer ATRAC files via NetMD likewise we can transfer WAV (PCM) files which are transcoded on-the-fly by the NetMD device into ATRAC-SP. What we can't do is encode ATRAC files ourselves as there is no known ATRAC encoder outside SonicStage/SoundForge. So, coming back to Maximo's question: Yes, you can transfer ATRAC files to the NetMD device and we can do it. The tracks end up on the Walkman as ATRAC anyway, since it's the only specified codec used for conventional MiniDiscs. If you can't provide ATRAC yourself but PCM (WAV files) only, the NetMD will take care of the transcoding. libnetmd supports ATRAC as well as PCM, but I am not 100% sure about the status quo. It might be that some sample rates are currently not supported, I have to look at the source code again. > > > And, if so, will be > >able to make trackmarks?I mean, I can do them in any track I record, > >but not in one I transfer using sonicstage, and I don't know if this > >is a limitation in hardware or just on sonicstage. > I think this is a limitation of the DRM system in Sony's atrac > format. Tracks transferred via sonicstage are copyright protected. > So, editing these tracks are not allowed. If you convert them into > .wav format first, and then using our software for transferring them > to the md unit, it should be able to set trackmarks then. I didn't > test this, if you want to do these tests, do them and please give > response to us if it works or not. It will work with tracks transferred with libnetmd/QHiMDTransfer as we don't set the DRM flag. Cheers, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From Michael.Karcher@fu-berlin.de Fri Dec 07 22:29:49 2012 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Th5US-002XhU-9E>; Fri, 07 Dec 2012 22:29:48 +0100 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.69) with esmtp (envelope-from ) id <1Th5US-000reM-1o>; Fri, 07 Dec 2012 22:29:48 +0100 Received: from port-92-204-90-247.dynamic.qsc.de ([92.204.90.247] helo=[192.168.178.21]) by inpost2.zedat.fu-berlin.de (Exim 4.69) with esmtpsa (envelope-from ) id <1Th5UR-000UNj-Sr>; Fri, 07 Dec 2012 22:29:48 +0100 Message-ID: <1354915814.27578.18.camel@localhost> From: Michael Karcher To: John Paul Adrian Glaubitz Date: Fri, 07 Dec 2012 22:30:14 +0100 In-Reply-To: <20121207201019.GA16699@physik.fu-berlin.de> References: <20121205162422.280930@gmx.net> <68017810383728760@unknownmsgid> <50BFCC2C.1070809@gmx.de> <20121207201019.GA16699@physik.fu-berlin.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: 92.204.90.247 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1354915788-00000B1F-EE846DCB/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000100, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Burundi.ZEDAT.FU-Berlin.DE X-Spam-Level: Cc: =?ISO-8859-1?Q?M=E1ximo?= Chicano =?ISO-8859-1?Q?D=EDaz?= , "linux-minidisc@lists.fu-berlin.de" Subject: Re: [linux-minidisc] implementing netmd support in the gui application X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2012 21:29:49 -0000 On Fri, 2012-12-07 at 21:10 +0100, John Paul Adrian Glaubitz wrote: > > I think Michael can give more information. > > This isn't actually correct. We can transfer ATRAC files via NetMD > likewise we can transfer WAV (PCM) files which are transcoded > on-the-fly by the NetMD device into ATRAC-SP. > > What we can't do is encode ATRAC files ourselves as there is no known > ATRAC encoder outside SonicStage/SoundForge. This is mostly true. There also is the ATRAC3 ACM codec pack by Sony, which is an ATRAC3 (which means LP2/LP4) encoder integrated in the ancient 32-bit Windows Multimedia system (which pre-dates DirectX / DirectShow). Too bad that the ACM support in Wine is not really present, which would otherwise be an elegant way to encode ATRAC3 in Linux. > So, coming back to Maximo's question: Yes, you can transfer ATRAC > files to the NetMD device and we can do it. To be more precise: We are able to transfer ATRAC3 (this is ATRAC LP2 and ATRAC LP4) as-is to NetMD devices. There should be some support of uploading ATRAC3 105kpbs (also known as LP3) too, which gets padded by the NetMD unit, so it is stored as LP2 on the medium. There is no support of transferring plain ATRAC (this is not ATRAC3), also known as ATRAC SP from the PC to the NetMD unit, but, as Adrian told you, you can create ATRAC SP tracks on NetMD units by sending raw PCM data, which gets encoded to ATRAC SP. There is no support for sending ATRAC3+ or ATRAC3 with bitrates different from LP2, LP3 or LP4 to the NetMD unit. > libnetmd supports ATRAC as well as PCM, but I am not 100% sure about > the status quo. It might be that some sample rates are currently not > supported, I have to look at the source code again. libnetmd does support all formats mentioned above, but the tool netmdcli does not. > > > And, if so, will be > > >able to make trackmarks?I mean, I can do them in any track I record, > > >but not in one I transfer using sonicstage, and I don't know if this > > >is a limitation in hardware or just on sonicstage. There are no trackmarks on the technical side of the MD world, but there is gapless playback of different tracks. Instead of setting a mark, you are splitting a track, so a new track begins at the mark. Splitting tracks is not allowed for tracks that are subject to DRM, as this would destroy the watermark used by the computer to identify a track when you check it in (delete it from the MD and increase the license counter on the computer). If the track was edited (split, merged and so on), you can't check it in, as the watermark does no longer match. So the intent of the prevention of setting "track marks" is not to limit the user, but to protect the user from losing his playback licenses. > It will work with tracks transferred with libnetmd/QHiMDTransfer as we > don't set the DRM flag. libnetmd does send a "these tracks are not subject to DRM" command to the NetMD unit, but not all units support this command. Older units mark them as DRMed tracks even if this command has been sent (and been rejected as invalid command). I don't know which units support getting tracks from the computer without marking them as protected. Best regards, Michael Karcher From glaubitz@physik.fu-berlin.de Sun Dec 09 22:54:09 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Thop6-0007iT-NY>; Sun, 09 Dec 2012 22:54:08 +0100 Received: from mx.physik.fu-berlin.de ([160.45.64.218]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Thop6-002nVg-Lm>; Sun, 09 Dec 2012 22:54:08 +0100 Received: from squeeze64.physik.fu-berlin.de ([160.45.66.239] helo=login.physik.fu-berlin.de) by mx.physik.fu-berlin.de with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Thop5-0002pt-F7 for linux-minidisc@lists.fu-berlin.de; Sun, 09 Dec 2012 22:54:07 +0100 Received: from glaubitz by login.physik.fu-berlin.de with local (Exim 4.72 #1 (Debian)) id 1Thop5-0005ei-Dr for ; Sun, 09 Dec 2012 22:54:07 +0100 Date: Sun, 9 Dec 2012 22:54:07 +0100 From: John Paul Adrian Glaubitz To: linux-minidisc@lists.fu-berlin.de Message-ID: <20121209215407.GA21693@physik.fu-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: John Paul Adrian Glaubitz X-Originating-IP: 160.45.64.218 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1355090048-00000B1F-7B63D200/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Benin.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: [linux-minidisc] [ANNOUNCE] linux-minidisc is now in Debian X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Dec 2012 21:54:09 -0000 Hey there, I am very pleased and proud to announce that linux-minidisc has finally been upload into Debian. This means, from today on anyone who is running Debian unstable can now easily install qhimdtransfer and the command line utilities without having to resort to external package repositories. A simple: > apt-get update && apt-get install qhimdtransfer minidisc-utils will install both the command line utilities and qhimdtransfer onto your Debian box. However, since the packages were just installed into the unstable repositories and Debian testing is currently in its feature freeze, linux-minidisc won't be part of the Debian Wheezy release but its successor Debian Jessie. There is also currently a bug in the qmake project files which prevent a successful build on any FreeBSD platform, this includes the Debian kFreeBSD blends. We will fix that in the next upstream release. As for Ubuntu users, they have to wait for the release of Ubuntu 13.04 (Codename "Raring Ringtail") for linux-minidisc to be included. It will then even be available for download through the Ubuntu Software Center. Thanks a lot for everyone who made this happen :). Cheers, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From Michael.Karcher@fu-berlin.de Sun Dec 16 15:40:15 2012 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TkFO2-001Apx-Hc>; Sun, 16 Dec 2012 15:40:14 +0100 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.69) with esmtp (envelope-from ) id <1TkFO2-0018it-Fp>; Sun, 16 Dec 2012 15:40:14 +0100 Received: from port-92-204-64-24.dynamic.qsc.de ([92.204.64.24] helo=[192.168.178.21]) by inpost2.zedat.fu-berlin.de (Exim 4.69) with esmtpsa (envelope-from ) id <1TkFO2-003Des-Ae>; Sun, 16 Dec 2012 15:40:14 +0100 Message-ID: <1355668859.5110.31.camel@localhost> From: Michael Karcher To: Kevin Chabowski Date: Sun, 16 Dec 2012 15:40:59 +0100 In-Reply-To: References: <1352159486.23866.180.camel@localhost> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: 92.204.64.24 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1355668814-00000B1F-CD375BBC/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001432, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Burundi.ZEDAT.FU-Berlin.DE X-Spam-Level: Cc: linux-minidisc@lists.fu-berlin.de Subject: Re: [linux-minidisc] Implementing downloading in QHiMDTransfer X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2012 14:40:15 -0000 On Sun, 2012-11-18 at 14:19 +0100, Kevin Chabowski wrote: > Sorry, that I didn't reply earlier. 3rd semester at university is much > more time consuming than I thought... Sorry for the long delay, too. Your patches were not forgotten. > But here are finally fixes for the first 8 (now 5) patches. The first three have been applied to the repository (after deleting one trailing space in the third one). > > | From e096e749587e50da5c72bb0afa7da5bbd0e1c725 Mon Sep 17 00:00:00 2001 > > | From: Kevin Chabowski > > | Date: Mon, 22 Oct 2012 21:43:35 +0200 > > | Subject: [PATCH 07/16] himd_set_track_label implemented > > This patch definitely does not pass quality control. While you describe > > being able to change existing labels, and it appears to work fine at the > > beginning, you are leaking HiMD strings. The 14-byte string fragments > > that are unused are organized in a linked freelist. When you change a > > title, you have to add all the string fragments used by the title back > > into the freelist (and change the type nibble to zero) to prevent > > loosing these "string slots" until the next formatting of the disk. > In the new himd_set_track_label patch there is now a function to properly > delete strings, which himd_set_track_label now calls before adding the new > string. This looks fine now, but some comments on the himd_delete_string function: It would be nice if it implemeted a transactional model, if easily possible (i.e. it should change nothing if it returns -1), and it should check for error conditions wherevere reasonable to prevent messing up a partly invalid disc. For the transactional model, I would suggest you traverse the chain twice - once to check its validity, and a second time to change the flags. In the first round, do not only check that the non-head fragments have the type "continuation", but also that the first fragment is neither unused nor continuation. (Check himd_get_string_raw) You might also want to check the range of the string index (compare there, too). A trap my comments might lead you into is that if you just check the validity in the first round, you could get into an endless loop. There are two ways to fix that: - Do *not* do two iterations, but *do* change the flags from the string type or "continuation" to "unused" (don't change the links, though). If everything is fine, link the last item to the freelist head, and linkt the freelist head to the first item. If something is fishy, undo what you did. (This means you have to store the type field of the first chunk, though) - Count the number of links you followed. If you followed more than 4096 links, you must be in an infinite loop. Besides, as a style issue, please put a space around the "*" character when declaring pointer variables and arguments as it is done in the other parts of that file, too. > label_type is now an enum and is checked using g_return_val_if_fail. Looks fine. > > The himd_modify_track approach is quite dangerous, as it relies on the > > user to pass the right track index to it. > Okay, the patch now introduces himd_start_update_track_info and > himd_commit_update_track_info like you suggested. There is one detail I dislike, but on a second look, it might be fine: himd_commit_track_info takes an himderrinfo parameter, but given valid parameters, it can not fail. So it could be a void function, too. (Use g_return_if_fail instead of g_return_val_if_fail). It might be fine if you intend to have it easier adapted in case settrack might return an error. Are you aware you don't need the parenthesis in &(t->data)? Something I noted, but is not easily fixable (and I explicitly don't ask you to fix, and I forbid you to fix it in the same patch as you do the retitling) is that the current architecture of the code does not easily allow you to make that function efficiently transactional. There is no way to check whether "there will be enough space to store a given string after another string has been deleted". One could implement that by splitting the conversion of the string to the on-disk encoding, the free-space check and the inserting of the data into three pieces, and having the himd_set_string function first convert the new string, then find the length of the old string (in chunks), calculate the number of extra chunks needed and peek for that number of chunks in the free list. Then delete the old string and set the new string as it is done now. > > | From ffd91b653bef249d38d9ecde18a5d993fc8a081d Mon Sep 17 00:00:00 2001 > > | From: Kevin Chabowski > > | Date: Mon, 22 Oct 2012 22:15:00 +0200 > > | Subject: [PATCH 08/16] Using himd_set_track_label in himd_writemp3 of > > himdcli > > This patch looks fine, except for error handling (printing a warning) if > > himd_set_track_label fails. > > Okay, prints an error on failure now. This patch is fine now, I didn't apply that because I didn't apply the previous patch. Thank you very much for the time you spent on improving linux-minidisc stuff! Kind regards, Michael Karcher From linux-minidisc@lists.fu-berlin.de Sun Dec 16 15:42:29 2012 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TkFQC-001B3r-78>; Sun, 16 Dec 2012 15:42:28 +0100 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TkFQC-0018wM-5i>; Sun, 16 Dec 2012 15:42:28 +0100 Received: from z6.physik.fu-berlin.de ([160.45.66.66] helo=z6) by inpost2.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtps (envelope-from ) id <1TkFQC-003DlZ-4D>; Sun, 16 Dec 2012 15:42:28 +0100 Received: from mkarcher by z6 with local (Exim 4.80) (envelope-from ) id 1TkFQB-0000Hy-Tx for linux-minidisc@lists.fu-berlin.de; Sun, 16 Dec 2012 15:42:28 +0100 To: linux-minidisc@lists.fu-berlin.de MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 2377053a147674f9b7ea0e98d3e3596e19284d67 X-Git-Newrev: f6ae9880ef04a4b5a40935dcf6e95678d33145ad Message-Id: From: Michael Karcher Date: Sun, 16 Dec 2012 15:42:27 +0100 X-Originating-IP: 160.45.66.66 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1355668948-00000B1F-90ABC081/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Gabun.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: [linux-minidisc] [commit] Linux utilities to deal with Sony Minidisc Walkman branch master updated. 0.9.5-3-gf6ae988 X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2012 14:42:29 -0000 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Linux utilities to deal with Sony Minidisc Walkman". The branch, master has been updated via f6ae9880ef04a4b5a40935dcf6e95678d33145ad (commit) via c6579ffdf71ce1b49078605b5723185f553c1368 (commit) via 9b19aee600958b28b31532ba720f206177387bac (commit) from 2377053a147674f9b7ea0e98d3e3596e19284d67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f6ae9880ef04a4b5a40935dcf6e95678d33145ad Author: Kevin Chabowski Date: Sat Nov 17 12:56:23 2012 +0100 Moved get_songinfo from himdcli to libhimd So we can reuse it later in the GUI. commit c6579ffdf71ce1b49078605b5723185f553c1368 Author: Kevin Chabowski Date: Sat Nov 10 14:41:53 2012 +0100 Activating download button, if appropiate. * If a file was selected and a HiMD was opened, activate the download button. * Added a dummy on_clicked function for the download button. commit 9b19aee600958b28b31532ba720f206177387bac Author: Kevin Chabowski Date: Sat Nov 10 14:05:33 2012 +0100 Replaced on_localScan_clicked with selectionChanged handler * A signal handler is now used to process user input for localScan tree, since this will also handle keyboard navigation. * Renamed `handle_selection_change` to `handle_himd_selection_change` to make it unambiguous which selection change should be processed. ----------------------------------------------------------------------- Summary of changes: himdcli/himdcli.c | 48 +----------------------- libhimd/himd.h | 6 ++- libhimd/libhimd.pro | 2 +- libhimd/mp3tools.c | 74 +++++++++++++++++++++++++++++++++++++ qhimdtransfer/qhimdmainwindow.cpp | 39 +++++++++++++------ qhimdtransfer/qhimdmainwindow.h | 5 ++- 6 files changed, 113 insertions(+), 61 deletions(-) create mode 100644 libhimd/mp3tools.c hooks/post-receive -- Linux utilities to deal with Sony Minidisc Walkman From linux-minidisc@lists.fu-berlin.de Wed Dec 19 19:55:33 2012 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TlOnk-003HXy-Ep>; Wed, 19 Dec 2012 19:55:32 +0100 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TlOnk-0007ar-DP>; Wed, 19 Dec 2012 19:55:32 +0100 Received: from z6.physik.fu-berlin.de ([160.45.66.66] helo=z6) by inpost2.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtps (envelope-from ) id <1TlOnk-003Vku-Bx>; Wed, 19 Dec 2012 19:55:32 +0100 Received: from glaubitz by z6 with local (Exim 4.80) (envelope-from ) id 1TlOnj-00005Y-ON for linux-minidisc@lists.fu-berlin.de; Wed, 19 Dec 2012 19:55:31 +0100 To: linux-minidisc@lists.fu-berlin.de MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: f6ae9880ef04a4b5a40935dcf6e95678d33145ad X-Git-Newrev: ff9a453152d73c80972221b388d2d0d3c5796ce1 Message-Id: From: John Paul Adrian Glaubitz Date: Wed, 19 Dec 2012 19:55:31 +0100 X-Originating-IP: 160.45.66.66 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1355943332-00000B1F-86EB33EB/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Dschibuti.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: [linux-minidisc] [commit] Linux utilities to deal with Sony Minidisc Walkman branch master updated. 0.9.5-4-gff9a453 X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2012 18:55:33 -0000 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Linux utilities to deal with Sony Minidisc Walkman". The branch, master has been updated via ff9a453152d73c80972221b388d2d0d3c5796ce1 (commit) from f6ae9880ef04a4b5a40935dcf6e95678d33145ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff9a453152d73c80972221b388d2d0d3c5796ce1 Author: John Paul Adrian Glaubitz Date: Wed Dec 19 19:54:06 2012 +0100 Drop -lusb-1.0 from LIBS in libnetmd.pro as pkg-config takes care of the proper location of the libraries. ----------------------------------------------------------------------- Summary of changes: libnetmd/libnetmd.pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Linux utilities to deal with Sony Minidisc Walkman From linux-minidisc@lists.fu-berlin.de Thu Dec 20 01:19:55 2012 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TlTre-003gPb-5n>; Thu, 20 Dec 2012 01:19:54 +0100 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TlTre-000jpu-47>; Thu, 20 Dec 2012 01:19:54 +0100 Received: from z6.physik.fu-berlin.de ([160.45.66.66] helo=z6) by inpost2.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtps (envelope-from ) id <1TlTre-003nPD-2c>; Thu, 20 Dec 2012 01:19:54 +0100 Received: from glaubitz by z6 with local (Exim 4.80) (envelope-from ) id 1TlTrd-0007rn-Vf for linux-minidisc@lists.fu-berlin.de; Thu, 20 Dec 2012 01:19:54 +0100 To: linux-minidisc@lists.fu-berlin.de MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: ff9a453152d73c80972221b388d2d0d3c5796ce1 X-Git-Newrev: 0b716e007b14ecb346dfcc79c3a1712f277709b9 Message-Id: From: John Paul Adrian Glaubitz Date: Thu, 20 Dec 2012 01:19:53 +0100 X-Originating-IP: 160.45.66.66 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1355962794-00000B1F-939B1603/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Botsuana.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: [linux-minidisc] [commit] Linux utilities to deal with Sony Minidisc Walkman branch master updated. 0.9.5-5-g0b716e0 X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2012 00:19:55 -0000 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Linux utilities to deal with Sony Minidisc Walkman". The branch, master has been updated via 0b716e007b14ecb346dfcc79c3a1712f277709b9 (commit) from ff9a453152d73c80972221b388d2d0d3c5796ce1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0b716e007b14ecb346dfcc79c3a1712f277709b9 Author: John Paul Adrian Glaubitz Date: Thu Dec 20 01:19:34 2012 +0100 Update VERSION to 0.9.6. ----------------------------------------------------------------------- Summary of changes: VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Linux utilities to deal with Sony Minidisc Walkman From linux-minidisc@lists.fu-berlin.de Thu Dec 20 01:22:19 2012 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TlTty-003ge4-0t>; Thu, 20 Dec 2012 01:22:18 +0100 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TlTtx-000k6G-Vb>; Thu, 20 Dec 2012 01:22:18 +0100 Received: from z6.physik.fu-berlin.de ([160.45.66.66] helo=z6) by inpost2.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtps (envelope-from ) id <1TlTtx-003nWi-U7>; Thu, 20 Dec 2012 01:22:17 +0100 Received: from glaubitz by z6 with local (Exim 4.80) (envelope-from ) id 1TlTtx-0007x4-RF for linux-minidisc@lists.fu-berlin.de; Thu, 20 Dec 2012 01:22:17 +0100 To: linux-minidisc@lists.fu-berlin.de MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Refname: refs/tags/0.9.6 X-Git-Reftype: annotated tag X-Git-Oldrev: 0000000000000000000000000000000000000000 X-Git-Newrev: 1e54c5464e767fa5d52cecbec42fba69dfa88c34 Message-Id: From: John Paul Adrian Glaubitz Date: Thu, 20 Dec 2012 01:22:17 +0100 X-Originating-IP: 160.45.66.66 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1355962938-00000B1F-2910D3DD/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.270260, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Botsuana.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: [linux-minidisc] [commit] Linux utilities to deal with Sony Minidisc Walkman annotated tag 0.9.6 created. 0.9.6 X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2012 00:22:19 -0000 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Linux utilities to deal with Sony Minidisc Walkman". The annotated tag, 0.9.6 has been created at 1e54c5464e767fa5d52cecbec42fba69dfa88c34 (tag) tagging 0b716e007b14ecb346dfcc79c3a1712f277709b9 (commit) replaces 0.9.5 tagged by John Paul Adrian Glaubitz on Thu Dec 20 01:22:06 2012 +0100 - Log ----------------------------------------------------------------- Tag release 0.9.6. John Paul Adrian Glaubitz (2): Drop -lusb-1.0 from LIBS in libnetmd.pro as pkg-config takes care of the proper location of the libraries. Update VERSION to 0.9.6. Kevin Chabowski (3): Replaced on_localScan_clicked with selectionChanged handler Activating download button, if appropiate. Moved get_songinfo from himdcli to libhimd ----------------------------------------------------------------------- hooks/post-receive -- Linux utilities to deal with Sony Minidisc Walkman From manner.moe@gmx.de Sat Dec 22 15:16:04 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TmPrr-003FsI-UX>; Sat, 22 Dec 2012 15:16:00 +0100 Received: from mout.gmx.net ([212.227.17.21]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TmPrr-0004aU-Rz>; Sat, 22 Dec 2012 15:15:59 +0100 Received: from mailout-de.gmx.net ([10.1.76.69]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Lg2yr-1TK1Cf2VcR-00pe7Z for ; Sat, 22 Dec 2012 15:15:58 +0100 Received: (qmail invoked by alias); 22 Dec 2012 14:15:58 -0000 Received: from dslc-082-083-136-166.pools.arcor-ip.net (EHLO [192.168.2.100]) [82.83.136.166] by mail.gmx.net (mp069) with SMTP; 22 Dec 2012 15:15:58 +0100 X-Authenticated: #17747474 X-Provags-ID: V01U2FsdGVkX1+/jHU+lV+/1LFkJlbbJU4y90Z2SeycLlCuXzKsdr xpKWDAMAlEhDGO Message-ID: <50D5C01F.3090506@gmx.de> Date: Sat, 22 Dec 2012 15:13:51 +0100 From: Thomas Arp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: linux-minidisc@lists.fu-berlin.de References: <20121205162422.280930@gmx.net> In-Reply-To: <20121205162422.280930@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Originating-IP: 212.227.17.21 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356185759-00000B1F-29213911/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Checker-Version: SpamAssassin 3.3.2 on Gabun.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: Re: [linux-minidisc] implementing netmd support in the gui application X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Dec 2012 14:16:04 -0000 Hi, i made the first steps for the netmd support. You can find my work at my github account [1] at netmd_integration branch. Note, my github repo is not up to date (missing the last 4 commits). As i changed too many things i preferred to merge with the current master repo later and finish my first steps first. At current stage it supports netmd device autodetection at application startup (also autodetection at application runtime on windows), open and close netmd devices and displaying track information in the QTreeview. This includes switching between netmd and himd devices automatically. next steps i want to import: - moving track transfer routines from the mainwindow to the new class QHiMDDevice - implement netmd transfer routines I think something like QHiMDDevice::batchUpload(QHiMDTrackList tracklist) and QHiMDDevice::upload(QHiMDTrack track) should be o.k. Also using the same member names in QNetDMDevice class and batchDownload() and download() for the download routines. Please take a look at it, i think it needs some cleanup/optimation. Thomas [1] http://github.com/tharp/linux-minidisc From manner.moe@gmx.de Sun Dec 23 15:49:58 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TmmsH-003HTQ-1r>; Sun, 23 Dec 2012 15:49:57 +0100 Received: from mout.gmx.net ([212.227.15.18]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TmmsG-0027at-VC>; Sun, 23 Dec 2012 15:49:57 +0100 Received: from mailout-de.gmx.net ([10.1.76.36]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MLDN1-1TmVtK3GFt-000OJ2 for ; Sun, 23 Dec 2012 15:49:55 +0100 Received: (qmail invoked by alias); 23 Dec 2012 14:49:55 -0000 Received: from dslc-082-083-136-166.pools.arcor-ip.net (EHLO [192.168.2.100]) [82.83.136.166] by mail.gmx.net (mp036) with SMTP; 23 Dec 2012 15:49:55 +0100 X-Authenticated: #17747474 X-Provags-ID: V01U2FsdGVkX1+GLa8zTouGAZoEnwLzNTbcMY/N0elbGXN4PhRNOv Gv5h8LKf9E2tMQ Message-ID: <50D7199D.3010703@gmx.de> Date: Sun, 23 Dec 2012 15:47:57 +0100 From: Thomas Arp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: linux-minidisc@lists.fu-berlin.de References: <20121205162422.280930@gmx.net> <50D5C01F.3090506@gmx.de> In-Reply-To: <50D5C01F.3090506@gmx.de> Content-Type: multipart/mixed; boundary="------------050706040403040605030003" X-Y-GMX-Trusted: 0 X-Originating-IP: 212.227.15.18 X-ZEDAT-Hint: A X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356274197-00000B1F-43FF1E43/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Checker-Version: SpamAssassin 3.3.2 on Gabun.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: [linux-minidisc] implementing unix himd autodetection function X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2012 14:49:58 -0000 This is a multi-part message in MIME format. --------------050706040403040605030003 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi, now I made a first patch for the unix autodetection function during application runtime. At current stage it displays debug messages only. I think there is a way to get "allDrives" using dbus for detection at application start, but i didn't check this yet. We can fetch the corresponding driver file (/dev/sdX) and the mountpoint. I don't know if there is any way to get the vendor/product ids. Maybe it's enough to check if vendor/model strings are "Sony Hi-MD" and if connection interface is usb to accept the drive as himd device. Thomas --------------050706040403040605030003 Content-Type: text/x-patch; name="0001-implemented-unix-autodetection-function-during-appli.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-implemented-unix-autodetection-function-during-appli.pa"; filename*1="tch" >From 2e46fb4fce7ce9d8fdc138bf413c199873408372 Mon Sep 17 00:00:00 2001 From: Thomas Arp Date: Sun, 23 Dec 2012 15:33:28 +0100 Subject: [PATCH] implemented unix autodetection function during application runtime, does not change anything yet, just displaying debug messages. --- qhimdtransfer/qhimdtransfer.pro | 2 + qhimdtransfer/qhimdunixdetection.cpp | 149 ++++++++++++++++++++++++++++++++++ 2 files changed, 151 insertions(+) create mode 100644 qhimdtransfer/qhimdunixdetection.cpp diff --git a/qhimdtransfer/qhimdtransfer.pro b/qhimdtransfer/qhimdtransfer.pro index 236b5e9..d88486c 100644 --- a/qhimdtransfer/qhimdtransfer.pro +++ b/qhimdtransfer/qhimdtransfer.pro @@ -63,6 +63,8 @@ SOURCES += main.cpp \ qhimdmodel.cpp \ qhimddetection.cpp win32:SOURCES += qhimdwindetection.cpp +unix:SOURCES += qhimdunixdetection.cpp +unix:QT += dbus else:SOURCES += qhimddummydetection.cpp RESOURCES += icons.qrc PKGCONFIG += sox \ diff --git a/qhimdtransfer/qhimdunixdetection.cpp b/qhimdtransfer/qhimdunixdetection.cpp new file mode 100644 index 0000000..d573394 --- /dev/null +++ b/qhimdtransfer/qhimdunixdetection.cpp @@ -0,0 +1,149 @@ +#include +#include +#include +#include + +#define UDISK_SERVICE "org.freedesktop.UDisks" +#define UDISK_PATH "/org/freedesktop/UDisks" +#define UDISK_INTERFACE "org.freedesktop.UDisks" +#define UDISK_PROPERTIES "org.freedesktop.DBus.Properties" +#define UDISK_DEVICE "org.freedesktop.UDisks.Device" + +/* define property names */ +#define PROP_IS_DRIVE "DeviceIsDrive" +#define PROP_IS_MOUNTED "DeviceIsMounted" +#define PROP_DEV_FILE "DeviceFile" +#define PROP_MOUNTPATH "DeviceMountPaths" +#define PROP_D_VENDOR "DriveVendor" +#define PROP_D_MODEL "DriveModel" +#define PROP_D_CON_INT "DriveConnectionInterface" + +class QHiMDUnixDetection : public QHiMDDetection{ + Q_OBJECT + + QDBusConnection dbus_c; +public: + QHiMDUnixDetection(QObject * parent = NULL); + ~QHiMDUnixDetection() {} + +private: + QVariant get_property(QDBusObjectPath dbp, QString property); + bool isDrive(QDBusObjectPath dbp); + QString devicePath(QDBusObjectPath dbp); + QString driveVendor(QDBusObjectPath dbp); + QString driveModel(QDBusObjectPath dbp); + QString interface(QDBusObjectPath dbp); + bool isMounted(QDBusObjectPath dbp); + QString mountpoint(QDBusObjectPath dbp); + +private slots: + void deviceAdded(QDBusObjectPath dbop); + void deviceRemoved(QDBusObjectPath dbop); +}; + +QHiMDDetection * createDetection(QObject * parent) +{ + return new QHiMDUnixDetection(parent); +} + +QHiMDUnixDetection::QHiMDUnixDetection(QObject *parent) + : QHiMDDetection(parent), dbus_c( QDBusConnection::connectToBus( QDBusConnection::SystemBus, "system" ) ) +{ + if(!dbus_c.connect(UDISK_SERVICE, UDISK_PATH, UDISK_INTERFACE, "DeviceAdded", this, SLOT(deviceAdded(QDBusObjectPath)))) + qDebug() << "cannot receive DeviceAdded signals"; + + if(!dbus_c.connect(UDISK_SERVICE, UDISK_PATH, UDISK_INTERFACE, "DeviceRemoved", this, SLOT(deviceRemoved(QDBusObjectPath)))) + qDebug() << "cannot receive DeviceRemoved signals"; +} + +QVariant QHiMDUnixDetection::get_property(QDBusObjectPath dbp, QString property) +{ + QDBusMessage msg = QDBusMessage::createMethodCall(UDISK_SERVICE, dbp.path(), UDISK_PROPERTIES, "Get"); + QDBusVariant var; + QList args; + QDBusMessage reply; + QString sig; + + /* set arguments */ + args.append(UDISK_DEVICE); + args.append(property); + msg.setArguments(args); + + /* send message */ + reply = dbus_c.call(msg); + + sig = 'v'; + if (!reply.signature().compare(sig)) + { + if (reply.arguments().length() > 0) + { + /* return first argument only should be fine for our reasons */ + var = reply.arguments().at(0).value(); + return var.variant(); + } + } + return QVariant(); +} + +bool QHiMDUnixDetection::isDrive(QDBusObjectPath dbp) +{ + return get_property(dbp, PROP_IS_MOUNTED).toBool(); +} + +QString QHiMDUnixDetection::devicePath(QDBusObjectPath dbp) +{ + return get_property(dbp, PROP_DEV_FILE).toString(); +} + +QString QHiMDUnixDetection::driveVendor(QDBusObjectPath dbp) +{ + return get_property(dbp, PROP_D_VENDOR).toString(); +} + +QString QHiMDUnixDetection::driveModel(QDBusObjectPath dbp) +{ + return get_property(dbp, PROP_D_MODEL).toString(); +} + +QString QHiMDUnixDetection::interface(QDBusObjectPath dbp) +{ + return get_property(dbp, PROP_D_CON_INT).toString(); +} + +bool QHiMDUnixDetection::isMounted(QDBusObjectPath dbp) +{ + return get_property(dbp, PROP_IS_MOUNTED).toBool(); +} + +QString QHiMDUnixDetection::mountpoint(QDBusObjectPath dbp) +{ + return get_property(dbp, PROP_MOUNTPATH).toString(); +} + +void QHiMDUnixDetection::deviceAdded(QDBusObjectPath dev) +{ + qDebug() << "device added : " << dev.path(); + + /* this can be used for scsi acces (formatting etc.) */ + qDebug() << " system device driver file: " + devicePath(dev); + + /* wait for device to be mounted, this could take some time for himd devices, + if value is < 20 isDrive() and isMounted() may return false if mounting procedure didn't finish + excpecially on older devices of generation 1 (tested with RH1 and NH1)*/ + sleep(20); + + if(isDrive(dev)) { + qDebug() << QString(" Vendor/Model: %1 %2").arg(driveVendor(dev)).arg(driveModel(dev)); + qDebug() << QString(" connection interface: %1").arg(interface(dev)); + qDebug() << QString(" mountpoint is : %1").arg(isMounted(dev) ? mountpoint(dev) : "(not mounted)"); + } +} + +void QHiMDUnixDetection::deviceRemoved(QDBusObjectPath dev) +{ + qDebug() << "device removed : " << dev.path(); +} + +/* created moc file manually, this is needed if there is no header file for classes using signals/slots + else getting linker errors */ +#include "moc_qhimdunixdetection.cpp" -- 1.7.9.5 --------------050706040403040605030003-- From glaubitz@physik.fu-berlin.de Sun Dec 23 16:01:22 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tmn3J-003Mkk-Jn>; Sun, 23 Dec 2012 16:01:21 +0100 Received: from mx.physik.fu-berlin.de ([160.45.64.218]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tmn3J-0028st-I8>; Sun, 23 Dec 2012 16:01:21 +0100 Received: from zlogin.physik.fu-berlin.de ([160.45.66.4]) by mx.physik.fu-berlin.de with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Tmn3I-0003BC-B0 for linux-minidisc@lists.fu-berlin.de; Sun, 23 Dec 2012 16:01:20 +0100 Received: from glaubitz by zlogin.physik.fu-berlin.de with local (Exim 4.72 #1 (Debian)) id 1Tmn3I-00073j-9v for ; Sun, 23 Dec 2012 16:01:20 +0100 Date: Sun, 23 Dec 2012 16:01:20 +0100 From: John Paul Adrian Glaubitz To: linux-minidisc@lists.fu-berlin.de Message-ID: <20121223150120.GA27101@physik.fu-berlin.de> References: <20121205162422.280930@gmx.net> <50D5C01F.3090506@gmx.de> <50D7199D.3010703@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50D7199D.3010703@gmx.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: John Paul Adrian Glaubitz X-Originating-IP: 160.45.64.218 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356274881-00000B1F-CAFD2C29/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000238, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Benin.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: Re: [linux-minidisc] implementing unix himd autodetection function X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2012 15:01:22 -0000 On Sun, Dec 23, 2012 at 03:47:57PM +0100, Thomas Arp wrote: > now I made a first patch for the unix autodetection function during > application runtime. > At current stage it displays debug messages only. Hey, that's pretty cool. You're being really productive, congrats! > I think there is a way to get "allDrives" using dbus for detection > at application start, but i didn't check this yet. Well, dbus is an interprocess communication system. I am not sure whether you can actually enumarate devices through dbus. udev does this on Linux. > We can fetch the corresponding driver file (/dev/sdX) and the mountpoint. > I don't know if there is any way to get the vendor/product ids. > > Maybe it's enough to check if vendor/model strings are "Sony Hi-MD" > and if connection interface is usb to accept the drive as himd > device. An easy way would be to use udev which is unfortunately Linux-specific. udev emumerates devices and can assign device files according to specific properties (USB IDs, for example). With udev, you could have any HiMD/NetMD device known from a himd.rules/netmd.rules file assign the device file /dev/himdN or /dev/netmdN (N being an integer number). We might have to come up with an abstraction layer such that we have support for at least Linux, *BSD and MacOS X. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From glaubitz@physik.fu-berlin.de Sun Dec 23 16:28:46 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TmnTn-003ZOK-TT>; Sun, 23 Dec 2012 16:28:44 +0100 Received: from mx.physik.fu-berlin.de ([160.45.64.218]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TmnTn-002Btq-Rn>; Sun, 23 Dec 2012 16:28:43 +0100 Received: from zlogin.physik.fu-berlin.de ([160.45.66.4]) by mx.physik.fu-berlin.de with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1TmnTm-0003GH-Ke for linux-minidisc@lists.fu-berlin.de; Sun, 23 Dec 2012 16:28:42 +0100 Received: from glaubitz by zlogin.physik.fu-berlin.de with local (Exim 4.72 #1 (Debian)) id 1TmnTm-00076A-Jb for ; Sun, 23 Dec 2012 16:28:42 +0100 Date: Sun, 23 Dec 2012 16:28:42 +0100 From: John Paul Adrian Glaubitz To: linux-minidisc@lists.fu-berlin.de Message-ID: <20121223152842.GC27101@physik.fu-berlin.de> References: <20121205162422.280930@gmx.net> <50D5C01F.3090506@gmx.de> <50D7199D.3010703@gmx.de> <20121223150120.GA27101@physik.fu-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121223150120.GA27101@physik.fu-berlin.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: John Paul Adrian Glaubitz X-Originating-IP: 160.45.64.218 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356276523-00000B1F-A63C0AB1/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Algerien.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: Re: [linux-minidisc] implementing unix himd autodetection function X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2012 15:28:46 -0000 On Sun, Dec 23, 2012 at 04:01:20PM +0100, John Paul Adrian Glaubitz wrote: > An easy way would be to use udev which is unfortunately > Linux-specific. udev emumerates devices and can assign device files > according to specific properties (USB IDs, for example). With udev, > you could have any HiMD/NetMD device known from a > himd.rules/netmd.rules file assign the device file /dev/himdN or > /dev/netmdN (N being an integer number). As a quick follow up, here's a good introductory guide to writing udev rules [1]. However, I think we should discuss the whole auto detection mechanism on Linux, *BSD and MacOS X on more detail before we start implementing it so we can be sure to have maximum cross-platform compatibility. Adrian > [1] http://www.reactivated.net/writing_udev_rules.html -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From manner.moe@gmx.de Sun Dec 23 21:22:46 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tms4L-000zG9-8i>; Sun, 23 Dec 2012 21:22:45 +0100 Received: from mout.gmx.net ([212.227.17.21]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tms4L-002jBF-4r>; Sun, 23 Dec 2012 21:22:45 +0100 Received: from mailout-de.gmx.net ([10.1.76.39]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MLlXB-1Tm37Y3HO7-000raT for ; Sun, 23 Dec 2012 21:22:43 +0100 Received: (qmail invoked by alias); 23 Dec 2012 20:22:43 -0000 Received: from dslc-082-083-136-166.pools.arcor-ip.net (EHLO [192.168.2.100]) [82.83.136.166] by mail.gmx.net (mp039) with SMTP; 23 Dec 2012 21:22:43 +0100 X-Authenticated: #17747474 X-Provags-ID: V01U2FsdGVkX18FXftxTrEFUUNiRzIu7YjVaVWnsjNTpiCvrWwYyE mwsl0CSPdZXXN/ Message-ID: <50D7679C.3090603@gmx.de> Date: Sun, 23 Dec 2012 21:20:44 +0100 From: Thomas Arp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: John Paul Adrian Glaubitz References: <20121205162422.280930@gmx.net> <50D5C01F.3090506@gmx.de> <50D7199D.3010703@gmx.de> <20121223150120.GA27101@physik.fu-berlin.de> <20121223152842.GC27101@physik.fu-berlin.de> In-Reply-To: <20121223152842.GC27101@physik.fu-berlin.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Originating-IP: 212.227.17.21 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356294165-00000B1F-9DBF7F2B/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Checker-Version: SpamAssassin 3.3.2 on Botsuana.ZEDAT.FU-Berlin.DE X-Spam-Level: Cc: linux-minidisc@lists.fu-berlin.de Subject: Re: [linux-minidisc] implementing unix himd autodetection function X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2012 20:22:46 -0000 Am 23.12.2012 16:28, schrieb John Paul Adrian Glaubitz: > On Sun, Dec 23, 2012 at 04:01:20PM +0100, John Paul Adrian Glaubitz wrote: >> An easy way would be to use udev which is unfortunately >> Linux-specific. udev emumerates devices and can assign device files >> according to specific properties (USB IDs, for example). With udev, >> you could have any HiMD/NetMD device known from a >> himd.rules/netmd.rules file assign the device file /dev/himdN or >> /dev/netmdN (N being an integer number). > As a quick follow up, here's a good introductory guide to writing udev > rules [1]. However, I think we should discuss the whole auto detection > mechanism on Linux, *BSD and MacOS X on more detail before we start > implementing it so we can be sure to have maximum cross-platform > compatibility. > > Adrian > >> [1] http://www.reactivated.net/writing_udev_rules.html I took a look at udev-discoverer gui application to see which information we can get from udev. Is there any way to get the mountpoint? I cannot find anything about that. If not maybe we can use dbus to get the device file and "DriveAdded"/"DriveRemoved" notification and use udev to get the device information for the specified device file. Or better use the other way: use udev to get notifications and device information and than use dbus to get the mountpoint if device is a himd device. Also maybe we could make use of libudev to provide autodetection mechanism without the need to create/install any udev rules. I think netmd detection at application start is mostly platform independent using libusb, libusb provides it's own enumeration function as used in libnetmd. We just need device added/removed notification to reenumerate libusb devices. I will read some more about udev. Thomas From glaubitz@physik.fu-berlin.de Sun Dec 23 23:40:33 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1TmuDg-001usv-3d>; Sun, 23 Dec 2012 23:40:32 +0100 Received: from mx.physik.fu-berlin.de ([160.45.64.218]) by relay1.zedat.fu-berlin.de (Exim 4.69) with esmtp (envelope-from ) id <1TmuDg-002vY4-1t>; Sun, 23 Dec 2012 23:40:32 +0100 Received: from squeeze64.physik.fu-berlin.de ([160.45.66.239] helo=login.physik.fu-berlin.de) by mx.physik.fu-berlin.de with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1TmuDd-0005cx-Rf; Sun, 23 Dec 2012 23:40:29 +0100 Received: from glaubitz by login.physik.fu-berlin.de with local (Exim 4.72 #1 (Debian)) id 1TmuDd-0003Qz-QH; Sun, 23 Dec 2012 23:40:29 +0100 Date: Sun, 23 Dec 2012 23:40:29 +0100 From: John Paul Adrian Glaubitz To: Thomas Arp Message-ID: <20121223224029.GA13130@physik.fu-berlin.de> References: <20121205162422.280930@gmx.net> <50D5C01F.3090506@gmx.de> <50D7199D.3010703@gmx.de> <20121223150120.GA27101@physik.fu-berlin.de> <20121223152842.GC27101@physik.fu-berlin.de> <50D7679C.3090603@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50D7679C.3090603@gmx.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: John Paul Adrian Glaubitz X-Originating-IP: 160.45.64.218 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356302432-00000B1F-DCDCCCE6/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED X-Spam-Checker-Version: SpamAssassin 3.3.2 on Botsuana.ZEDAT.FU-Berlin.DE X-Spam-Level: Cc: linux-minidisc@lists.fu-berlin.de Subject: Re: [linux-minidisc] implementing unix himd autodetection function X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2012 22:40:33 -0000 On Sun, Dec 23, 2012 at 09:20:44PM +0100, Thomas Arp wrote: > I took a look at udev-discoverer gui application to see which > information we can get from udev. Is there any way to get the > mountpoint? I cannot find anything about that. I don't think you can. The basic idea of udev is to trigger on hardware events and changes and then set up devices files or call external programs according to the rules files. What I meant to say is that with udev, you can set a permanent name for the HiMD device node and then have it mounted to a specific location. This will also avoid having to rely on auto-mount mechanisms which you don't have when using window managers like awesome or any desktop environment which doesn't mount devices automatically (unlike GNOME/MATE/KDE). > If not maybe we can > use dbus to get the device file and "DriveAdded"/"DriveRemoved" > notification and use udev to get the device information for the > specified device file. Hmm, yes, maybe. But, as I said, I wouldn't rely on auto-mounting. It's not present on any configuration. > Also maybe we could make use of libudev to provide autodetection > mechanism without the need to create/install any udev rules. That might be possible as well, I haven't used libudev before. But rules files aren't that much of a burden. They are actually quite easy to use. > I think netmd detection at application start is mostly platform > independent using libusb, libusb provides it's own enumeration > function as used in libnetmd. We just need device added/removed > notification to reenumerate libusb devices. True. I was realizing it the moment I wrote it. I actually dealt with the code myself when porting libnetmd from the old libusb to libusb 1.0. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 From kevin@kch42.de Tue Dec 25 23:33:11 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tnd3e-001Qb1-TD>; Tue, 25 Dec 2012 23:33:11 +0100 Received: from static.98.70.47.78.clients.your-server.de ([78.47.70.98] helo=skadu-server.mine.nu) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tnd3e-002zNy-NU>; Tue, 25 Dec 2012 23:33:10 +0100 Received: from localhost.localdomain (localhost [127.0.0.1]) by skadu-server.mine.nu (Postfix) with ESMTPA id BD7751C114E; Tue, 25 Dec 2012 23:26:48 +0100 (CET) Content-Type: multipart/mixed; boundary=----------62Uc3PHG8tMDSQ5NckuXPM References: <1352159486.23866.180.camel@localhost> <1355668859.5110.31.camel@localhost> To: "Michael Karcher" Date: Tue, 25 Dec 2012 23:25:07 +0100 MIME-Version: 1.0 From: "Kevin Chabowski" Message-ID: In-Reply-To: <1355668859.5110.31.camel@localhost> User-Agent: Opera Mail/12.12 (Linux) X-Originating-IP: 78.47.70.98 X-ZEDAT-Hint: GA X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356474790-00000B1F-BFE03806/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.005600, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=2.0 required=5.0 tests=FU_XZH_G X-Spam-Checker-Version: SpamAssassin 3.3.2 on Burundi.ZEDAT.FU-Berlin.DE X-Spam-Level: xx Cc: linux-minidisc@lists.fu-berlin.de Subject: Re: [linux-minidisc] Implementing downloading in QHiMDTransfer X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2012 22:33:11 -0000 ------------62Uc3PHG8tMDSQ5NckuXPM Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Am 16.12.2012, 15:40 Uhr, schrieb Michael Karcher : >> > | From e096e749587e50da5c72bb0afa7da5bbd0e1c725 Mon Sep 17 00:00:00 >> 2001 >> > | From: Kevin Chabowski >> > | Date: Mon, 22 Oct 2012 21:43:35 +0200 >> > | Subject: [PATCH 07/16] himd_set_track_label implemented [...] > This looks fine now, but some comments on the himd_delete_string > function: > It would be nice if it implemeted a transactional model, if easily > possible (i.e. it should change nothing if it returns -1), and it should > check for error conditions wherevere reasonable to prevent messing up a > partly invalid disc. Okay, I implemented the first version: It changes the types of the chunks in the string to unused and if something went wrong, it will restore the chain, before returning an error. A strange behavior I observed: On one of my discs (recorded with SonicStage using an RH10) the renaming process fails completely. Although the old string seemed to be deleted correctly (the delete function didn't return -1) and the new string was also written, the old string was still there in the next track-listing. To make things even more weird, the new string was much shorter than the old one, so it would not occupy the same amount of string chunks. Still, the old string was there with intact linking. It worked just fine on another disc. I double-checked that the write protection of the HiMD was deactivated. I ran the program step-by-step in a debugger, still I do not have a clue, what goes wrong here. (btw. is there a simpler way to enable debug infos than manually manipulating the generated makefiles?) Is this a known issue? > Besides, as a style issue, please put a space around the "*" character > when declaring pointer variables and arguments as it is done in the > other parts of that file, too. Okay, changed that. > There is one detail I dislike, but on a second look, it might be fine: > himd_commit_track_info takes an himderrinfo parameter, but given valid > parameters, it can not fail. So it could be a void function, too. (Use > g_return_if_fail instead of g_return_val_if_fail). It might be fine if > you intend to have it easier adapted in case settrack might return an > error. Yes, it will be easier, if settrack changes. Also I personally think it is not good, if the function would not indicate an error if it had an error (a simple return from a void function). Since most (all?) functions that can return an error code also have a himderrinfo parameter, I included that one, too. Other functions also do this (e.g. himd_add_track_info). So at the moment I left it that way. Of course I can change this, if it is bad style. (But I added a `(void)status;`, so the compiler does not complain about an unused parameter.) > Are you aware you don't need the parenthesis in &(t->data)? I personally think, it makes it more readable to wrap it in parenthesis. I now left it this way, but again, I will change this, if it bugs you. Kevin ------------62Uc3PHG8tMDSQ5NckuXPM Content-Disposition: attachment; filename=0001-himd_set_track_label-implemented.patch Content-Type: application/octet-stream; name=0001-himd_set_track_label-implemented.patch Content-Transfer-Encoding: Base64 RnJvbSA1NDIxMzI4NmNkYTE3YjhmYjBkYzc1MmI1OTMwYzEwYTdkMTA3ZjVkIE1v biBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBDaGFib3dza2kgPGtl dmluQGtjaDQyLmRlPgpEYXRlOiBUdWUsIDI1IERlYyAyMDEyIDEyOjA5OjMzICsw MTAwClN1YmplY3Q6IFtQQVRDSCAxLzJdIGhpbWRfc2V0X3RyYWNrX2xhYmVsIGlt cGxlbWVudGVkCgoqIGhpbWRfc2V0X3RyYWNrX2xhYmVsIGNhbiBzZXQgdGhlIHRp dGxlL2FydGlzdC9hbGJ1bSBsYWJlbCBvZiBhIHRyYWNrCiogQWxzbyBhZGRlZCBo aW1kX21vZGlmeV90cmFja19pbmZvIHdoaWNoIG1ha2VzIGl0IGEgYml0IGVhc2ll ciB0byBtb2RpZnkKICB0cmFjayBpbmZvcyBvZiBhbHJlYWR5IGV4aXN0aW5nIHRy YWNrcy4KKiBOaWNlIHNpZGUtZWZmZWN0OiBoaW1kY2xpIGNhbiBub3cgc2V0IHRp dGxlL2FydGlzdC9hbGJ1bSBvZiB0cmFja3MuCi0tLQogaGltZGNsaS9oaW1kY2xp LmMgICAgfCAgNDkgKysrKysrKysrKysrLS0tLQogbGliaGltZC9oaW1kLmggICAg ICAgfCAgMTYgKysrKysrCiBsaWJoaW1kL3RyYWNraW5kZXguYyB8IDE1NSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK IDMgZmlsZXMgY2hhbmdlZCwgMjA5IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2hpbWRjbGkvaGltZGNsaS5jIGIvaGltZGNsaS9o aW1kY2xpLmMKaW5kZXggM2IxNTY3OC4uMjA5MjhmNiAxMDA2NDQKLS0tIGEvaGlt ZGNsaS9oaW1kY2xpLmMKKysrIGIvaGltZGNsaS9oaW1kY2xpLmMKQEAgLTE2LDE3 ICsxNiwyMCBAQAogCiB2b2lkIHVzYWdlKGNoYXIgKiBjbWRuYW1lKQogewotICBw cmludGYoIlVzYWdlOiAlcyA8SGlNRCBwYXRoPiA8Y29tbWFuZD4sIHdoZXJlIDxj b21tYW5kPiBpcyBlaXRoZXIgb2Y6XG5cblwKLSAgICAgICAgICBzdHJpbmdzICAg ICAgICAgIC0gZHVtcHMgYWxsIHN0cmluZ3MgZm91bmQgaW4gdGhlIHRyYWNrbGlz dCBmaWxlXG5cCi0gICAgICAgICAgdHJhY2tzICAgICAgICAgICAtIGxpc3RzIGFs bCB0cmFja3Mgb24gZGlzY1xuXAotICAgICAgICAgIHRyYWNrcyB2ZXJib3NlICAg LSBsaXN0cyBkZXRhaWxzIG9mIGFsbCB0cmFja3Mgb24gZGlzY1xuXAotICAgICAg ICAgIGRpc2NpZCAgICAgICAgICAgLSByZWFkcyB0aGUgZGlzYyBpZCBvZiB0aGUg aW5zZXJ0ZWQgbWVkaXVtXG5cCi0gICAgICAgICAgaG9sZXMgICAgICAgICAgICAt IGxpc3RzIGFsbCBob2xlcyBvbiBkaXNjXG5cCi0gICAgICAgICAgbXAza2V5IDxU Uks+ICAgICAtIHNob3cgdGhlIE1QMyBlbmNyeXB0aW9uIGtleSBmb3IgdHJhY2sg PFRSSz5cblwKLSAgICAgICAgICBkdW1wdHJhY2sgPFRSSz4gIC0gZHVtcCB0cmFj ayA8VFJLPlxuXAotICAgICAgICAgIGR1bXBtcDMgPFRSSz4gICAgLSBkdW1wIE1Q MyB0cmFjayA8VFJLPlxuXAotICAgICAgICAgIGR1bXBub25tcDMgPFRSSz4gLSBk dW1wIG5vbi1NUDMgdHJhY2sgPFRSSz5cblwKLSAgICAgICAgICB3cml0ZW1wMyA8 RklMRT4gIC0gd3JpdGUgbXAzIHRvIGRpc2NcbiIsIGNtZG5hbWUpOworICBwcmlu dGYoIlVzYWdlOiAlcyA8SGlNRCBwYXRoPiA8Y29tbWFuZD4sIHdoZXJlIDxjb21t YW5kPiBpcyBlaXRoZXIgb2Y6XG5cbiIKKyAgICAgICAgICIgIHN0cmluZ3MgICAg ICAgICAgICAgICAgICAtIGR1bXBzIGFsbCBzdHJpbmdzIGZvdW5kIGluIHRoZSB0 cmFja2xpc3QgZmlsZVxuIgorICAgICAgICAgIiAgdHJhY2tzICAgICAgICAgICAg ICAgICAgIC0gbGlzdHMgYWxsIHRyYWNrcyBvbiBkaXNjXG4iCisgICAgICAgICAi ICB0cmFja3MgdmVyYm9zZSAgICAgICAgICAgLSBsaXN0cyBkZXRhaWxzIG9mIGFs bCB0cmFja3Mgb24gZGlzY1xuIgorICAgICAgICAgIiAgZGlzY2lkICAgICAgICAg ICAgICAgICAgIC0gcmVhZHMgdGhlIGRpc2MgaWQgb2YgdGhlIGluc2VydGVkIG1l ZGl1bVxuIgorICAgICAgICAgIiAgaG9sZXMgICAgICAgICAgICAgICAgICAgIC0g bGlzdHMgYWxsIGhvbGVzIG9uIGRpc2NcbiIKKyAgICAgICAgICIgIG1wM2tleSA8 VFJLPiAgICAgICAgICAgICAtIHNob3cgdGhlIE1QMyBlbmNyeXB0aW9uIGtleSBm b3IgdHJhY2sgPFRSSz5cbiIKKyAgICAgICAgICIgIGR1bXB0cmFjayA8VFJLPiAg ICAgICAgICAtIGR1bXAgdHJhY2sgPFRSSz5cbiIKKyAgICAgICAgICIgIGR1bXBt cDMgPFRSSz4gICAgICAgICAgICAtIGR1bXAgTVAzIHRyYWNrIDxUUks+XG4iCisg ICAgICAgICAiICBkdW1wbm9ubXAzIDxUUks+ICAgICAgICAgLSBkdW1wIG5vbi1N UDMgdHJhY2sgPFRSSz5cbiIKKyAgICAgICAgICIgIHdyaXRlbXAzIDxGSUxFPiAg ICAgICAgICAtIHdyaXRlIG1wMyB0byBkaXNjXG4iCisgICAgICAgICAiICBzZXR0 aXRsZSA8VFJLPiA8VElUTEU+ICAgLSBTZXQgPFRSSz4ncyB0aXRsZSB0byA8VElU TEU+XG4iCisgICAgICAgICAiICBzZXRhcnRpc3QgPFRSSz4gPEFSVElTVD4gLSBT ZXQgPFRSSz4ncyBhcnRpc3QgdG8gPEFSVElTVD5cbiIKKyAgICAgICAgICIgIHNl dGFsYnVtIDxUUks+IDxBTEJVTT4gICAtIFNldCA8VFJLPidzIGFsYnVtIHRvIDxB TEJVTT5cbiIsIGNtZG5hbWUpOwogfQogCiBzdGF0aWMgY29uc3QgY2hhciAqIGhl eGR1bXAodW5zaWduZWQgY2hhciAqIGlucHV0LCBpbnQgbGVuKQpAQCAtNzIzLDYg KzcyNiwxMiBAQCB2b2lkIGhpbWRfd3JpdGVtcDMoc3RydWN0IGhpbWQgICpoLCBj b25zdCBjaGFyICpmaWxlcGF0aCkKICAgICBmcmVlKGFydGlzdCk7IGZyZWUoYWxi dW0pOyBmcmVlKHRpdGxlKTsKIH0KIAordm9pZCBoaW1kX3JlbGFiZWxfdHJhY2so c3RydWN0IGhpbWQgKiBoLCBpbnQgaWR4LCBjaGFyICogbGFiZWwsIGludCBsYWJl bF90eXBlKQoreworICAgIGhpbWRfc2V0X3RyYWNrX2xhYmVsKGgsIGlkeCwgbGFi ZWwsIGxhYmVsX3R5cGUsIE5VTEwpOworICAgIGhpbWRfd3JpdGVfdGlmZGF0YSho LCBOVUxMKTsKK30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiogYXJndikK IHsKICAgICBpbnQgaWR4OwpAQCAtNzgzLDYgKzc5MiwyNCBAQCBpbnQgbWFpbihp bnQgYXJnYywgY2hhciAqKiBhcmd2KQogICAgIHsKIAloaW1kX3dyaXRlbXAzKCZo LCBhcmd2WzNdKTsKICAgICB9CisgICAgZWxzZSBpZihzdHJjbXAoYXJndlsyXSwi c2V0dGl0bGUiKSA9PSAwICYmIGFyZ2MgPiA0KQorICAgIHsKKyAgICAgICAgaWR4 ID0gMTsKKyAgICAgICAgc3NjYW5mKGFyZ3ZbM10sICIlZCIsICZpZHgpOworICAg ICAgICBoaW1kX3JlbGFiZWxfdHJhY2soJmgsIGlkeCwgYXJndls0XSwgTEFCRUxf VFlQRV9USVRMRSk7CisgICAgfQorICAgIGVsc2UgaWYoc3RyY21wKGFyZ3ZbMl0s InNldGFydGlzdCIpID09IDAgJiYgYXJnYyA+IDQpCisgICAgeworICAgICAgICBp ZHggPSAxOworICAgICAgICBzc2NhbmYoYXJndlszXSwgIiVkIiwgJmlkeCk7Cisg ICAgICAgIGhpbWRfcmVsYWJlbF90cmFjaygmaCwgaWR4LCBhcmd2WzRdLCBMQUJF TF9UWVBFX0FSVElTVCk7CisgICAgfQorICAgIGVsc2UgaWYoc3RyY21wKGFyZ3Zb Ml0sInNldGFsYnVtIikgPT0gMCAmJiBhcmdjID4gNCkKKyAgICB7CisgICAgICAg IGlkeCA9IDE7CisgICAgICAgIHNzY2FuZihhcmd2WzNdLCAiJWQiLCAmaWR4KTsK KyAgICAgICAgaGltZF9yZWxhYmVsX3RyYWNrKCZoLCBpZHgsIGFyZ3ZbNF0sIExB QkVMX1RZUEVfQUxCVU0pOworICAgIH0KIAogICAgIGhpbWRfY2xvc2UoJmgpOwog ICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEvbGliaGltZC9oaW1kLmggYi9saWJo aW1kL2hpbWQuaAppbmRleCA2YTNhYTE2Li5kZjU5YmM4IDEwMDY0NAotLS0gYS9s aWJoaW1kL2hpbWQuaAorKysgYi9saWJoaW1kL2hpbWQuaApAQCAtMTc5LDYgKzE3 OSwyMiBAQCBpbnQgaGltZF9nZXRfZnJlZV90cmFja2luZGV4KHN0cnVjdCBoaW1k ICogaGltZCk7CiBpbnQgaGltZF9hZGRfdHJhY2tfaW5mbyhzdHJ1Y3QgaGltZCAq IGhpbWQsIHN0cnVjdCB0cmFja2luZm8gKiB0cmFjaywgc3RydWN0IGhpbWRlcnJp bmZvICogc3RhdHVzKTsKIGludCBoaW1kX2FkZF9mcmFnbWVudF9pbmZvKHN0cnVj dCBoaW1kICogaGltZCwgc3RydWN0IGZyYWdpbmZvICogZiwgc3RydWN0IGhpbWRl cnJpbmZvICogc3RhdHVzKTsKIAorc3RydWN0IGhpbWRfZWRpdGFibGVfdHJhY2tp bmZvIHsKKwlzdHJ1Y3QgdHJhY2tpbmZvIGRhdGE7CisJaW50IGluZGV4OworfTsK KworaW50IGhpbWRfc3RhcnRfdXBkYXRlX3RyYWNrX2luZm8oc3RydWN0IGhpbWQg KiBoaW1kLCB1bnNpZ25lZCBpbnQgaWR4LCBzdHJ1Y3QgaGltZF9lZGl0YWJsZV90 cmFja2luZm8gKiB0LCBzdHJ1Y3QgaGltZGVycmluZm8gKiBzdGF0dXMpOworaW50 IGhpbWRfY29tbWl0X3VwZGF0ZV90cmFja19pbmZvKHN0cnVjdCBoaW1kICogaGlt ZCwgc3RydWN0IGhpbWRfZWRpdGFibGVfdHJhY2tpbmZvICogdCwgc3RydWN0IGhp bWRlcnJpbmZvICogc3RhdHVzKTsKKworZW51bSBoaW1kX2xhYmVsX3R5cGUgewor CUxBQkVMX1RZUEVfVElUTEUsCisJTEFCRUxfVFlQRV9BUlRJU1QsCisJTEFCRUxf VFlQRV9BTEJVTQorfTsKKworaW50IGhpbWRfc2V0X3RyYWNrX2xhYmVsKHN0cnVj dCBoaW1kICogaGltZCwgaW50IHRyYWNraW5kZXgsIGNvbnN0IGNoYXIgKiBsYWJl bCwgZW51bSBoaW1kX2xhYmVsX3R5cGUgbGFiZWxfdHlwZSwgc3RydWN0IGhpbWRl cnJpbmZvICogc3RhdHVzKTsKKwogI2RlZmluZSBoaW1kX2dldF9jb2RlY19uYW1l KHRyYWNrKSBzb255X2NvZGVjaW5mb19jb2RlY25hbWUoJih0cmFjayktPmNvZGVj X2luZm8pCiAjZGVmaW5lIGhpbWRfdHJhY2tpbmZvX2ZyYW1lc2l6ZSh0cmFjaykg c29ueV9jb2RlY2luZm9fYnl0ZXNwZXJmcmFtZSgmKHRyYWNrKS0+Y29kZWNfaW5m bykKIHVuc2lnbmVkIGludCBoaW1kX3RyYWNraW5mb19mcmFtZXNwZXJibG9jayhj b25zdCBzdHJ1Y3QgdHJhY2tpbmZvICogdHJhY2spOwpkaWZmIC0tZ2l0IGEvbGli aGltZC90cmFja2luZGV4LmMgYi9saWJoaW1kL3RyYWNraW5kZXguYwppbmRleCBj OGZlNDM0Li4xY2U3MzVkIDEwMDY0NAotLS0gYS9saWJoaW1kL3RyYWNraW5kZXgu YworKysgYi9saWJoaW1kL3RyYWNraW5kZXguYwpAQCAtMjczLDYgKzI3MywzOCBA QCBpbnQgaGltZF9hZGRfdHJhY2tfaW5mbyhzdHJ1Y3QgaGltZCAqIGhpbWQsIHN0 cnVjdCB0cmFja2luZm8gKiB0LCBzdHJ1Y3QgaGltZGVycgogfQogCiAKK2ludCBo aW1kX3N0YXJ0X3VwZGF0ZV90cmFja19pbmZvKHN0cnVjdCBoaW1kICogaGltZCwg dW5zaWduZWQgaW50IGlkeCwgc3RydWN0IGhpbWRfZWRpdGFibGVfdHJhY2tpbmZv ICogdCwgc3RydWN0IGhpbWRlcnJpbmZvICogc3RhdHVzKQoreworICAgIGdfcmV0 dXJuX3ZhbF9pZl9mYWlsKGhpbWQgIT0gTlVMTCwgLTEpOworICAgIGdfcmV0dXJu X3ZhbF9pZl9mYWlsKHQgIT0gTlVMTCwgLTEpOworCisgICAgaWYoaGltZF9nZXRf dHJhY2tfaW5mbyhoaW1kLCBpZHgsICYodC0+ZGF0YSksIHN0YXR1cykgPCAwKQor ICAgIHsKKyAgICAgICAgdC0+aW5kZXggPSAtMTsKKyAgICAgICAgcmV0dXJuIC0x OworICAgIH0KKworICAgIHQtPmluZGV4ID0gaWR4OworCisgICAgcmV0dXJuIDA7 Cit9CisKK2ludCBoaW1kX2NvbW1pdF91cGRhdGVfdHJhY2tfaW5mbyhzdHJ1Y3Qg aGltZCAqIGhpbWQsIHN0cnVjdCBoaW1kX2VkaXRhYmxlX3RyYWNraW5mbyAqIHQs IHN0cnVjdCBoaW1kZXJyaW5mbyAqIHN0YXR1cykKK3sKKyAgICB1bnNpZ25lZCBj aGFyICogdHJhY2tidWZmZXI7CisKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbCho aW1kICE9IE5VTEwsIC0xKTsKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbCh0ICE9 IE5VTEwsIC0xKTsKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbCh0LT5pbmRleCA+ PSAwLCAtMSk7CisKKyAgICB0cmFja2J1ZmZlciA9IGdldF90cmFjayhoaW1kLCB0 LT5pbmRleCk7CisgICAgc2V0dHJhY2soJih0LT5kYXRhKSwgdHJhY2tidWZmZXIp OworCisgICAgKHZvaWQpc3RhdHVzOworICAgIHJldHVybiAwOworfQorCisKIHVu c2lnbmVkIGludCBoaW1kX3RyYWNraW5mb19mcmFtZXNwZXJibG9jayhjb25zdCBz dHJ1Y3QgdHJhY2tpbmZvICogdHJhY2spCiB7CiAgICAgaW50IGZyYW1lc2l6ZTsK QEAgLTU3OCwzICs2MTAsMTI2IEBAIGludCBoaW1kX2FkZF9zdHJpbmcoc3RydWN0 IGhpbWQgKiBoaW1kLCBjaGFyICpzdHJpbmcsIGludCB0eXBlLCBzdHJ1Y3QgaGlt ZGVycmluCiAKICAgICByZXR1cm4gaWR4X2ZpcnN0c2xvdDsKIH0KKworaW50IGhp bWRfZGVsZXRlX3N0cmluZyhzdHJ1Y3QgaGltZCAqIGhpbWQsIHVuc2lnbmVkIGlu dCBpZHgsIHN0cnVjdCBoaW1kZXJyaW5mbyAqIHN0YXR1cykKK3sKKyAgICB1bnNp Z25lZCBjaGFyICogY3VyX3N0cmNodW5rID0gTlVMTDsKKyAgICB1bnNpZ25lZCBj aGFyICogZnJlZWxpc3RfaGVhZCA9IE5VTEw7CisgICAgdW5zaWduZWQgaW50IGN1 cmlkeCwgZmFpbGVkX2F0OworICAgIGludCB0eXBlX29mX2hlYWQ7CisgICAgZ2Jv b2xlYW4gZmlyc3QgPSBUUlVFOworICAgIGdib29sZWFuIGZhaWxlZCA9IEZBTFNF OworCisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoaWR4ICE9IDAsIC0xKTsgLyog aWR4PT0wIGlzIHRoZSBoZWFkIG9mIHRoZSBmcmVlIGxpc3QgKi8KKworICAgIGZy ZWVsaXN0X2hlYWQgPSBnZXRfc3RyY2h1bmsoaGltZCwgMCk7CisgICAgdHlwZV9v Zl9oZWFkID0gc3RydHlwZShnZXRfc3RyY2h1bmsoaGltZCwgaWR4KSk7CisKKyAg ICBpZigodHlwZV9vZl9oZWFkID09IFNUUklOR19UWVBFX0NPTlRJTlVBVElPTikg fHwgKHR5cGVfb2ZfaGVhZCA9PSBTVFJJTkdfVFlQRV9VTlVTRUQpKQorICAgIHsK KyAgICAgICAgc2V0X3N0YXR1c19wcmludGYoc3RhdHVzLCBISU1EX0VSUk9SX05P VF9TVFJJTkdfSEVBRCwgIlN0cmluZyB0YWJsZSBlbnRyeSAlZCBpcyBub3QgYSBo ZWFkOiBUeXBlICVkIiwgY3VyaWR4LCB0eXBlX29mX2hlYWQpOworICAgICAgICBm YWlsZWQgPSBUUlVFOworICAgIH0KKworICAgIGN1cmlkeCA9IGlkeDsKKyAgICB3 aGlsZSgoY3VyaWR4ID4gMCkgJiYgKCFmYWlsZWQpKSAvKiBjdXJpZHggPT0gMCAt LT4gRW5kIG9mIHN0cmluZyAqLworICAgIHsKKyAgICAgICAgY3VyX3N0cmNodW5r ID0gZ2V0X3N0cmNodW5rKGhpbWQsIGN1cmlkeCk7CisKKyAgICAgICAgaWYoKCFm aXJzdCkgJiYgKHN0cnR5cGUoY3VyX3N0cmNodW5rKSAhPSBTVFJJTkdfVFlQRV9D T05USU5VQVRJT04pKQorICAgICAgICB7CisgICAgICAgICAgICBzZXRfc3RhdHVz X3ByaW50ZihzdGF0dXMsIEhJTURfRVJST1JfU1RSSU5HX0NIQUlOX0JST0tFTiwg IlN0cmluZyBzbG90ICVkIGhhcyB0eXBlICVkLCBzaG91bGQgYmUgJWRcbiIsIGN1 cmlkeCwgc3RydHlwZShjdXJfc3RyY2h1bmspLCBTVFJJTkdfVFlQRV9DT05USU5V QVRJT04pOworICAgICAgICAgICAgZmFpbGVkID0gVFJVRTsKKyAgICAgICAgICAg IGJyZWFrOworICAgICAgICB9CisKKyAgICAgICAgc2V0X3N0cnR5cGUoY3VyX3N0 cmNodW5rLCBTVFJJTkdfVFlQRV9VTlVTRUQpOyAvKiBNYXJrIGN1cnJlbnQgY2h1 bmsgYXMgdW51c2VkICovCisKKyAgICAgICAgY3VyaWR4ID0gc3RybGluayhjdXJf c3RyY2h1bmspOworICAgICAgICBmaXJzdCA9IEZBTFNFOworICAgIH0KKworICAg IGlmKGZhaWxlZCkKKyAgICB7CisgICAgICAgIC8qIFJlc3RvcmUgY2hhaW4gKi8K KyAgICAgICAgZmFpbGVkX2F0ID0gY3VyaWR4OworCisgICAgICAgIGN1cmlkeCA9 IGlkeDsKKyAgICAgICAgd2hpbGUoY3VyaWR4ICE9IGZhaWxlZF9hdCkKKyAgICAg ICAgeworICAgICAgICAgICAgY3VyX3N0cmNodW5rID0gZ2V0X3N0cmNodW5rKGhp bWQsIGN1cmlkeCk7CisgICAgICAgICAgICBzZXRfc3RydHlwZShjdXJfc3RyY2h1 bmssIFNUUklOR19UWVBFX0NPTlRJTlVBVElPTik7CisKKyAgICAgICAgICAgIGN1 cmlkeCA9IHN0cmxpbmsoY3VyX3N0cmNodW5rKTsKKyAgICAgICAgfQorCisgICAg ICAgIC8qIFJlc3RvcmUgdHlwZV9vZl9oZWFkICovCisgICAgICAgIGN1cl9zdHJj aHVuayA9IGdldF9zdHJjaHVuayhoaW1kLCBpZHgpOworICAgICAgICBzZXRfc3Ry dHlwZShjdXJfc3RyY2h1bmssIHR5cGVfb2ZfaGVhZCk7CisKKyAgICAgICAgcmV0 dXJuIC0xOworICAgIH0KKyAgICBlbHNlCisgICAgeworICAgICAgICBzZXRfc3Ry bGluayhjdXJfc3RyY2h1bmssIHN0cmxpbmsoZnJlZWxpc3RfaGVhZCkpOyAvKiBj dXJfc3RyY2h1bmsgd2FzIHRoZSBsYXN0IGNodW5rIG9mIG91ciBzdHJpbmcgKi8K KyAgICAgICAgc2V0X3N0cmxpbmsoZnJlZWxpc3RfaGVhZCwgaWR4KTsKKyAgICAg ICAgcmV0dXJuIDA7CisgICAgfQorfQorCitpbnQgaGltZF9zZXRfdHJhY2tfbGFi ZWwoc3RydWN0IGhpbWQgKiBoaW1kLCBpbnQgdHJhY2tpbmRleCwgY29uc3QgY2hh ciAqIGxhYmVsLCBlbnVtIGhpbWRfbGFiZWxfdHlwZSBsYWJlbF90eXBlLCBzdHJ1 Y3QgaGltZGVycmluZm8gKiBzdGF0dXMpCit7CisgICAgc3RydWN0IGhpbWRfZWRp dGFibGVfdHJhY2tpbmZvIHQ7CisgICAgaW50IHN0cmluZ19pZHg7CisgICAgaW50 IHJ2ID0gMDsKKyAgICBpbnQgKiBzdHJpbmdfZHN0OworICAgIGludCBzdHJpbmdf dHlwZTsKKworICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKGhpbWQgIT0gTlVMTCwg LTEpOworICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKGxhYmVsICE9IE5VTEwsIC0x KTsKKworICAgIGlmKGhpbWRfc3RhcnRfdXBkYXRlX3RyYWNrX2luZm8oaGltZCwg dHJhY2tpbmRleCwgJnQsIHN0YXR1cykgPCAwKQorICAgICAgICByZXR1cm4gLTE7 CisKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbCgobGFiZWxfdHlwZSA9PSBMQUJF TF9UWVBFX1RJVExFKSAgfHwKKyAgICAgICAgICAgICAgICAgICAgICAgICAobGFi ZWxfdHlwZSA9PSBMQUJFTF9UWVBFX0FSVElTVCkgfHwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAobGFiZWxfdHlwZSA9PSBMQUJFTF9UWVBFX0FMQlVNKSwgLTEp OworCisgICAgc3dpdGNoKGxhYmVsX3R5cGUpCisgICAgeworICAgICAgICBjYXNl IExBQkVMX1RZUEVfVElUTEU6CisgICAgICAgICAgICBzdHJpbmdfZHN0ID0gJih0 LmRhdGEudGl0bGUpOworICAgICAgICAgICAgc3RyaW5nX3R5cGUgPSBTVFJJTkdf VFlQRV9USVRMRTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIExB QkVMX1RZUEVfQVJUSVNUOgorICAgICAgICAgICAgc3RyaW5nX2RzdCA9ICYodC5k YXRhLmFydGlzdCk7CisgICAgICAgICAgICBzdHJpbmdfdHlwZSA9IFNUUklOR19U WVBFX0FSVElTVDsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIExB QkVMX1RZUEVfQUxCVU06CisgICAgICAgICAgICBzdHJpbmdfZHN0ID0gJih0LmRh dGEuYWxidW0pOworICAgICAgICAgICAgc3RyaW5nX3R5cGUgPSBTVFJJTkdfVFlQ RV9BTEJVTTsKKyAgICAgICAgICAgIGJyZWFrOworICAgIH0KKworICAgIGlmKCpz dHJpbmdfZHN0ICE9IDApCisgICAgeworICAgICAgICBpZihoaW1kX2RlbGV0ZV9z dHJpbmcoaGltZCwgKnN0cmluZ19kc3QsIHN0YXR1cykgPCAwKQorICAgICAgICAg ICAgcmV0dXJuIC0xOworICAgIH0KKworICAgICpzdHJpbmdfZHN0ID0gMDsKKwor ICAgIGlmKHN0cmNtcChsYWJlbCwgIiIpICE9IDApCisgICAgeworICAgICAgICBz dHJpbmdfaWR4ID0gaGltZF9hZGRfc3RyaW5nKGhpbWQsIGxhYmVsLCBzdHJpbmdf dHlwZSwgc3RhdHVzKTsKKyAgICAgICAgaWYoc3RyaW5nX2lkeCA8IDApCisgICAg ICAgICAgICBydiA9IC0xOyAvKiBBbiBlcnJvciBvY2N1cnJlZCwgYnV0IHdlIHNo b3VsZCBub3QganVzdCByZXR1cm4gLTEgaGVyZSwgc2luY2UgKnN0cmluZ19kc3Qg PSAwIHdhcyBub3QgY29tbWl0dGVkIHlldC4gKi8KKyAgICAgICAgZWxzZQorICAg ICAgICAgICAgKnN0cmluZ19kc3QgPSBzdHJpbmdfaWR4OworICAgIH0KKworICAg IGlmKGhpbWRfY29tbWl0X3VwZGF0ZV90cmFja19pbmZvKGhpbWQsICZ0LCBzdGF0 dXMpIDwgMCkKKyAgICAgICAgcmV0dXJuIC0xOworCisgICAgcmV0dXJuIHJ2Owor fQotLSAKMS44LjAuMgoK ------------62Uc3PHG8tMDSQ5NckuXPM Content-Disposition: attachment; filename*0="0002-Using-himd_set_track_label-in-himd_"; filename*1="writemp3-of-himdc.patch" Content-Type: application/octet-stream; name*0="0002-Using-himd_set_track_label-in-himd_"; name*1="writemp3-of-himdc.patch" Content-Transfer-Encoding: Base64 RnJvbSBiYzUxYjFmMTNlZjMxZTA1MTc2NzQwZTVlZmYyMjU5NTQ1OTUzODZjIE1v biBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBDaGFib3dza2kgPGtl dmluQGtjaDQyLmRlPgpEYXRlOiBUdWUsIDI1IERlYyAyMDEyIDEyOjIzOjI2ICsw MTAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIFVzaW5nIGhpbWRfc2V0X3RyYWNrX2xh YmVsIGluIGhpbWRfd3JpdGVtcDMgb2YgaGltZGNsaQoKLS0tCiBoaW1kY2xpL2hp bWRjbGkuYyB8IDQ3ICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwg MzQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvaGltZGNsaS9oaW1kY2xpLmMg Yi9oaW1kY2xpL2hpbWRjbGkuYwppbmRleCAyMDkyOGY2Li41MGEzYWYxIDEwMDY0 NAotLS0gYS9oaW1kY2xpL2hpbWRjbGkuYworKysgYi9oaW1kY2xpL2hpbWRjbGku YwpAQCAtNjQ5LDQ2ICs2NDksMTUgQEAgdm9pZCBoaW1kX3dyaXRlbXAzKHN0cnVj dCBoaW1kICAqaCwgY29uc3QgY2hhciAqZmlsZXBhdGgpCiAgICAgaWR4X2ZyYWcg ID0gaGltZF9hZGRfZnJhZ21lbnRfaW5mbyhoLCAmZnJhZ21lbnQsICZzdGF0dXMp OwogICAgIC8vIEVORDogQWRkIGZyYWdtZW50CiAKLSAgICAvLyBBZGQgc3RyaW5n cyBmb3IgdGl0bGUsIGFsYnVtIGFuZCBhcnRpc3QuIFJldHJpZXZlIHN0cmluZyBp bmRleCBudW1iZXJzLgotICAgIGdpbnQgaWR4X3RpdGxlPTAsIGlkeF9hbGJ1bT0w LCBpZHhfYXJ0aXN0PTA7Ci0KLSAgICBpZih0aXRsZSAhPSBOVUxMKSB7Ci0JaWR4 X3RpdGxlICA9IGhpbWRfYWRkX3N0cmluZyhoLCB0aXRsZSwgU1RSSU5HX1RZUEVf VElUTEUsICZzdGF0dXMpOwotCWlmKGlkeF90aXRsZSA8IDApCi0JICAgIHsKLQkJ cHJpbnRmKCJGYWlsZWQgdG8gYWRkIHRpdGxlIHN0cmluZ1xuIik7Ci0JCWlkeF90 aXRsZSA9IDA7Ci0JICAgIH0KLSAgICB9Ci0KLSAgICBpZihhbGJ1bSAhPSBOVUxM KSB7Ci0JaWR4X2FsYnVtICA9IGhpbWRfYWRkX3N0cmluZyhoLCBhbGJ1bSwgU1RS SU5HX1RZUEVfQUxCVU0sICZzdGF0dXMpOwotCWlmKGlkeF9hbGJ1bSA8IDApCi0J ICAgIHsKLQkJcHJpbnRmKCJGYWlsZWQgdG8gYWRkIGFsYnVtIHN0cmluZ1xuIik7 Ci0JCWlkeF9hbGJ1bSA9IDA7Ci0JICAgIH0KLSAgICB9Ci0KLSAgICBpZihhcnRp c3QgIT0gTlVMTCkgewotCWlkeF9hcnRpc3QgPSBoaW1kX2FkZF9zdHJpbmcoaCwg YXJ0aXN0LCBTVFJJTkdfVFlQRV9BUlRJU1QsICZzdGF0dXMpOwotCWlmKGlkeF9h cnRpc3QgPCAwKQotCSAgICB7Ci0JCXByaW50ZigiRmFpbGVkIHRvIGFkZCBhcnRp c3Qgc3RyaW5nXG4iKTsKLQkJaWR4X2FydGlzdCA9IDA7Ci0JICAgIH0KLSAgICB9 Ci0gICAgLy8gRU5EOiBBZGQgc3RyaW5ncwotCiAgICAgLy8KICAgICAvLyBBZGQg dHJhY2sgZGVzY3JpcHRvciwgZ2V0IHRyYWNrbm8gYmFjay4KICAgICAvLwogICAg IHN0cnVjdCB0cmFja2luZm8gdHJhY2s7CiAKICAgICBtZW1zZXQoJnRyYWNrLmtl eSwgMCwgOCk7IC8qIHVzZSB6ZXJvIGtleSBvbiBtcDMgZmlsZXMgKi8KLSAgICB0 cmFjay50aXRsZSAgPSBpZHhfdGl0bGU7Ci0gICAgdHJhY2suYXJ0aXN0ID0gaWR4 X2FydGlzdDsKLSAgICB0cmFjay5hbGJ1bSAgPSBpZHhfYWxidW07CisgICAgdHJh Y2sudGl0bGUgID0gMDsgLyogV2UnbGwgc2V0IHRpdGxlLCBhcnRpc3QgYW5kIGFs YnVtIGxhdGVyICovCisgICAgdHJhY2suYXJ0aXN0ID0gMDsKKyAgICB0cmFjay5h bGJ1bSAgPSAwOwogICAgIHRyYWNrLmZpcnN0ZnJhZyAgICA9IGlkeF9mcmFnOwog ICAgIHRyYWNrLnRyYWNrbnVtICAgICA9IDE7CiAgICAgdHJhY2suZWtibnVtICAg ICAgID0gMDsKQEAgLTcyMCw2ICs2ODksMTYgQEAgdm9pZCBoaW1kX3dyaXRlbXAz KHN0cnVjdCBoaW1kICAqaCwgY29uc3QgY2hhciAqZmlsZXBhdGgpCiAgICAgLy8g RU5EOiBBZGQgdHJhY2sgZGVzY3JpcHRvcgogCiAgICAgLy8KKyAgICAvLyBTZXQg dHJhY2sgbGFiZWxzCisgICAgLy8KKyAgICBpZihoaW1kX3NldF90cmFja19sYWJl bChoLCBpZHhfdHJhY2ssIHRpdGxlLCBMQUJFTF9UWVBFX1RJVExFLCAmc3RhdHVz KSA8IDApCisgICAgICAgIHByaW50ZigiRmFpbGVkIHRvIGFkZCB0aXRsZSBzdHJp bmdcbiIpOworICAgIGlmKGhpbWRfc2V0X3RyYWNrX2xhYmVsKGgsIGlkeF90cmFj aywgYXJ0aXN0LCBMQUJFTF9UWVBFX0FSVElTVCwgJnN0YXR1cykgPCAwKQorICAg ICAgICBwcmludGYoIkZhaWxlZCB0byBhZGQgYXJ0aXN0IHN0cmluZ1xuIik7Cisg ICAgaWYoaGltZF9zZXRfdHJhY2tfbGFiZWwoaCwgaWR4X3RyYWNrLCBhbGJ1bSwg TEFCRUxfVFlQRV9BTEJVTSwgJnN0YXR1cykgPCAwKQorICAgICAgICBwcmludGYo IkZhaWxlZCB0byBhZGQgYWxidW0gc3RyaW5nXG4iKTsKKworICAgIC8vCiAgICAg Ly8gVXBkYXRlIFRSQUNLLUlOREVYIGZpbGUgd2l0aCB0cmFjayBzdHJpbmdzLCBm cmFnbWVudCBkZXNjcmlwdG9yIGFuZCB0cmFjay1kZXNjcmlwdG9yLgogICAgIC8v CiAgICAgaGltZF93cml0ZV90aWZkYXRhKGgsICZzdGF0dXMpOwotLSAKMS44LjAu MgoK ------------62Uc3PHG8tMDSQ5NckuXPM-- From manner.moe@gmx.de Wed Dec 26 20:48:27 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tnwxm-002Skj-NF>; Wed, 26 Dec 2012 20:48:26 +0100 Received: from mout.gmx.net ([212.227.15.19]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tnwxm-000WUO-Jd>; Wed, 26 Dec 2012 20:48:26 +0100 Received: from mailout-de.gmx.net ([10.1.76.38]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0LpRRz-1TBIIX3W8z-00fFGg for ; Wed, 26 Dec 2012 20:48:24 +0100 Received: (qmail invoked by alias); 26 Dec 2012 19:48:24 -0000 Received: from dslc-082-083-136-166.pools.arcor-ip.net (EHLO [192.168.2.100]) [82.83.136.166] by mail.gmx.net (mp038) with SMTP; 26 Dec 2012 20:48:24 +0100 X-Authenticated: #17747474 X-Provags-ID: V01U2FsdGVkX1+S7kIlB8ySKpJZWbeOfHaPhlH1ubSjHvB2Gq4wVJ 4WTNTCwx2jefbs Message-ID: <50DB5405.70406@gmx.de> Date: Wed, 26 Dec 2012 20:46:13 +0100 From: Thomas Arp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: John Paul Adrian Glaubitz References: <20121205162422.280930@gmx.net> <50D5C01F.3090506@gmx.de> <50D7199D.3010703@gmx.de> <20121223150120.GA27101@physik.fu-berlin.de> <20121223152842.GC27101@physik.fu-berlin.de> <50D7679C.3090603@gmx.de> <20121223224029.GA13130@physik.fu-berlin.de> In-Reply-To: <20121223224029.GA13130@physik.fu-berlin.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Originating-IP: 212.227.15.19 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356551306-00000B1F-80E5148E/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Checker-Version: SpamAssassin 3.3.2 on Algerien.ZEDAT.FU-Berlin.DE X-Spam-Level: Cc: linux-minidisc@lists.fu-berlin.de Subject: Re: [linux-minidisc] implementing unix himd autodetection function X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2012 19:48:27 -0000 Am 23.12.2012 23:40, schrieb John Paul Adrian Glaubitz: > On Sun, Dec 23, 2012 at 09:20:44PM +0100, Thomas Arp wrote: >> I took a look at udev-discoverer gui application to see which >> information we can get from udev. Is there any way to get the >> mountpoint? I cannot find anything about that. > I don't think you can. The basic idea of udev is to trigger on > hardware events and changes and then set up devices files or call > external programs according to the rules files. O.K., i know you want to discuss autodetection function first but i'm just playing arround a bit ;) That's what i changed yet: - created a dbus connection and service with methods "AddMDDevice" and "RemoveMDDevice" listening to the session bus - getting mountpoint via system bus, also add function to mount the device via system bus if it is not mounted As qdbus is a part of Qt and qhimdtransfer depends on Qt, qdbus should be present on all machines where qhimdtransfer is installed. So we can use it to send messages to the session bus. TODO: create udev rule to use qdbus to send a message with following syntax: RUN+="qdbus com.trolltech.Qt /QHiMDUnixDetection AddMDDevice " (and RemoveMDDevice for ACTION=="remove") where is the corresponding kernel driver sdX (without path, just driver name!!) and are vendor/product id as integers, i think they have to be converted to decimal instead of hexadecimal, sending a message with 0x054c as vid doesn't work. I tested this by sending these messages with qdbus manually in a terminal and it works fine this way. I have to read a bit more about creating udev rules. I didn't create a working rule yet, i don't know how to set the arguments to the dbus command line correctly. But maybe it is better to use an extra script instead of sending the message in the rule itself. You can find it in netmd_integration2 branch at my github accout [1]. If this doesn't compile because of linker errors please recreate moc_qhimdunixdetection.cpp manually (type "moc qhimdunixdetection.cpp > moc_qhimdunixdetection.cpp" in qhimdtransfer directory). Thomas [1] http://github.com/tharp/linux-minidisc From manner.moe@gmx.de Sat Dec 29 18:20:23 2012 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tp058-002ZW3-HZ>; Sat, 29 Dec 2012 18:20:22 +0100 Received: from mout.gmx.net ([212.227.15.19]) by relay1.zedat.fu-berlin.de (Exim 4.69) for linux-minidisc@lists.fu-berlin.de with esmtp (envelope-from ) id <1Tp058-001jtM-F8>; Sat, 29 Dec 2012 18:20:22 +0100 Received: from mailout-de.gmx.net ([10.1.76.1]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MAiu5-1TukSE1Bnf-00BpJh for ; Sat, 29 Dec 2012 18:20:21 +0100 Received: (qmail invoked by alias); 29 Dec 2012 17:20:21 -0000 Received: from dslc-082-083-136-166.pools.arcor-ip.net (EHLO [192.168.2.100]) [82.83.136.166] by mail.gmx.net (mp001) with SMTP; 29 Dec 2012 18:20:21 +0100 X-Authenticated: #17747474 X-Provags-ID: V01U2FsdGVkX19x7PB2+K1x7FVHU1AUQR8HsBEF2iyvvF7zLNVxnu XNwjFnO5xWWYyh Message-ID: <50DF264D.1080206@gmx.de> Date: Sat, 29 Dec 2012 18:20:13 +0100 From: Thomas Arp User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: linux-minidisc@lists.fu-berlin.de References: <20121205162422.280930@gmx.net> <50D5C01F.3090506@gmx.de> <50D7199D.3010703@gmx.de> <20121223150120.GA27101@physik.fu-berlin.de> <20121223152842.GC27101@physik.fu-berlin.de> <50D7679C.3090603@gmx.de> <20121223224029.GA13130@physik.fu-berlin.de> <50DB5405.70406@gmx.de> In-Reply-To: <50DB5405.70406@gmx.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Originating-IP: 212.227.15.19 X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1356801622-00000B1F-E6D5D1BF/0-0/0-0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-Spam-Flag: NO X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Checker-Version: SpamAssassin 3.3.2 on Benin.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: Re: [linux-minidisc] implementing unix himd autodetection function X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Dec 2012 17:20:23 -0000 Hi, just another "playarround" for unix autodetection. You can find it at unix_udev branch on my github account [1]. This version uses libudev in combination with this [2] version of QUdev Qt wrapper class for libudev. No udev rules have to be created, libudev provides enumeration an monitoring functions. I didn't include QUdev in the repo, just copied to linux_minidisc folder added following line to QUdev.pro : "CONFIG += staticlib create_prl" to create a static lib and prl file. First built QUdev and than built qhimdtransfer by including QUdev prl file in qhimdtransfer.pro. I didn't include QUdev in the repo as this is just another test environment for autodetection mechanism and i had problems linking to QUdev dynamically. As my first versions, this version just displays debug messages only. Please read the comments in the source code, there are some hints on how to use this if we want a real minidisc autodetection function instead of just displaying messages. Thomas P.S.: You can find an newer version of QUdev at source forge, but i decided to use this version because it is very easy to use, matches our needs and doesn't need an extra monitoring class which just forwards the monitoring event signal from GUdev base class. [1] http://github.com/tharp/linux-minidisc [2] http://github.com/jpfeiffer/QUdev