Re: [linux-minidisc] Implementing downloading in QHiMDTransfer

From: John Paul Adrian Glaubitz &lt; glaubitz@physik.fu-berlin.de &gt;
To: Thomas Arp &lt; manner.moe@gmx.de &gt;
Date: Sun, 14 Oct 2012 21:09:10 +0200
Cc: Michael.Karcher@fu-berlin.de , linux-minidisc@lists.fu-berlin.de
Subject: Re: [linux-minidisc] Implementing downloading in QHiMDTransfer

John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> · Sun, 14 Oct 2012 21:09:10 +0200

Hi Thomas,

On Sun, Oct 14, 2012 at 07:15:54PM +0200, Thomas Arp wrote:
> Only files with supported extension are allowed to use, other files
> are not selectable and not enabled/grayed out in the file browser.
> Please take a look at it, maybe this will be committed into the master repo.

I've reviewed your current patch and I think the changes are fine to
be committed to git master. The patches apply against the current
master, the code still compiles and your changes have the desired
effect. I also couldn't find any problems with the code itself.

So, it's ok from my side. Just waiting for Michael to ackknowledge :).

Cheers,

Adrian