Re: [linux-minidisc] Implementing downloading in QHiMDTransfer

[John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>]

Hi,

On Wed, Oct 17, 2012 at 05:11:49PM +0200, Kevin Chabowski wrote:
> Here are already some patches. They don't enable downloading in GUI
> now, but they prepare this (moved get_songinfo to libhimd etc.).

Nice, that's a start. I'll have a look.

> Since I am not done now, it might not be a good idea to merge it
> into master (IMHO). Just a small update :-).

Don't worry, nothing gets merged into master unless Michael and I have
acknowledged the changes. We're quite strict regarding quality so it's
rather likely you will have to resend your changes several times until
they get accepted (which is normal if that's your first time writing
patches), but this way the code is guaranteed to work afterwards.

> Between patch 3 and 4 I merged the new local tree widget/model from
> master into my branch. Git did not produce a patch for that. Don't
> know, if this is correct (I am not used to the
> patch-to-maillist-workflow)?

I'm not sure, but I think it's correct. We'll have to see what Michael
thinks, he knows a bit more on git.

Adrian