FU Logo
  • Startseite
  • Kontakt
  • Impressum
  • Home
  • Listenauswahl
  • Anleitungen

Re: [linux-minidisc] Qt5 compatibility

<-- thread -->
<-- date -->
  • From: Thomas Arp <manner.moe@gmx.de>
  • To: "linux-minidisc@lists.fu-berlin.de" <linux-minidisc@lists.fu-berlin.de>
  • Date: Sun, 15 Dec 2013 22:30:33 +0100
  • Subject: Re: [linux-minidisc] Qt5 compatibility

Am 15.12.2013 22:29, schrieb Thomas Arp:
Am 15.12.2013 22:23, schrieb John Paul Adrian Glaubitz:
On 12/15/2013 10:16 PM, Thomas Arp wrote:
there is one more incompatibility with Qt5 in the QTime class. A QTime
object must be initialized before using it, else it will be invalid.
So current source code will not display track length if compiled with Qt5.
I made a small patch fixing this.
-        return t;
+        return QTime();
Are you sure this is correct? Shouldn't this still return the name
of the object and not the name of the class?

Adrian

Yes, i am sure this is correct.

return t; // returns a qtime object which is initialized with 0,0,0 -> so track list will show 00:00 as length return QTime(); // return an empty invalid QTime object, tracklist will show nothing btw. an empty string

I think this important, if the track length is smaller than 1 second the track list will show 00:00. If we use "return t;" we don't know if the track slot is valid or if the track is smaller than 1 second.

Thomas



<-- thread -->
<-- date -->
  • Follow-Ups:
    • Re: [linux-minidisc] Qt5 compatibility
      • From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
  • References:
    • [linux-minidisc] Qt5 compatibility
      • From: Thomas Arp <manner.moe@gmx.de>
    • Re: [linux-minidisc] Qt5 compatibility
      • From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
    • Re: [linux-minidisc] Qt5 compatibility
      • From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
    • Re: [linux-minidisc] Qt5 compatibility
      • From: Thomas Arp <manner.moe@gmx.de>
    • Re: [linux-minidisc] Qt5 compatibility
      • From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
  • linux-minidisc - December 2013 - Archives indexes sorted by:
    [ thread ] [ subject ] [ author ] [ date ]
  • Complete archive of the linux-minidisc mailing list
  • More info on this list...

Hilfe

  • FAQ
  • Dienstbeschreibung
  • ZEDAT Beratung
  • postmaster@lists.fu-berlin.de

Service-Navigation

  • Startseite
  • Listenauswahl

Einrichtung Mailingliste

  • ZEDAT-Portal
  • Mailinglisten Portal