Re: [linux-minidisc] netmd support for qhimdtransfer gui application

[Thomas Arp <manner.moe@gmx.de>]

Am 21.12.2013 20:03, schrieb John Paul Adrian Glaubitz:
> On 12/21/2013 05:35 PM, Thomas Arp wrote:
> > O.K., here is my updated patch rebased against the current repo on github.
> I have committed the first of the 6 patches now, it looks ok. Now for
> the second one:
>
> I think I would like to move the definitions in libnetmd_extended.h into
> libnetmd.h. It looks a bit clunky to have an extra header file required
> for libnetmd.
>
> Could you comment on this?
>
> Adrian
This is a bit difficult. libnetmd.h includes common.h which includes 
utils.h.
Take a look at my comment in libnetmd_extended.h. Definition of min() in 
utils.h is incompatible with the definition of min() used by taglib.

If we can fix this it is ok to move the definition to libnetmd.h

Thomas