Re: [linux-minidisc] Qt5 compatibility

[Michael Karcher <Michael.Karcher@fu-berlin.de>]

Am Sonntag, den 15.12.2013, 22:16 +0100 schrieb Thomas Arp:
> there is one more incompatibility with Qt5 in the QTime class. A QTime 
> object must be initialized before using it, else it will be invalid.
> So current source code will not display track length if compiled with Qt5.
> I made a small patch fixing this.

This patch is already applied as-is, which is what I would have done,
too. No problems with the patch or the code it touches.

(Although I somehow dislike the Qt choice of using the same class to
represent both time spans and time-of-day with the same class, resulting
in stuff like "QTime::elapsed() will wrap if the latest call of start()
or restart() is more than 24 hours ago", which will make our program
show wrong durations if there are tracks longer than 24 hours, sorry,
just *had* to dislike something about it...)

Regards,
  Michael Karcher