Re: [linux-minidisc] NetMD patches merged

[Thomas Arp <manner.moe@gmx.de>]

Am 05.01.2014 21:05, schrieb John Paul Adrian Glaubitz:
> The following patches will need additional work:
>
> 0010-netmd-support-add-support-for-usb-driver-installatio.patch
> 0012-netmd-support-add-unix-autodetection-during-applicat.patch
> 0013-unix-autodetection-fixed-getting-mountpoit-function-.patch
O.K., i will rebase my local master repo first.
I will send updated versions for these patches after discussion of the 
"additional work".

> As a side-question: Can one actually use NetMD in QHiMDTransfer
> without the auto-detect support? I couldn't find my MZ-RH1,
> I suppose it must be lying at work. Will check tomorrow.
Yes, one can use netmd devices if they are already conneted to the 
computer at application start.
The auto-detect support is just for device changes (add or remove) 
during application runtime.

> And these haven't been reviewed yet:
>
> 0001-support-netmd-downloads-for-any-.wav-file-containing.patch
> 0002-fixed-a-bug-in-byte-order-conversion-loop.patch
> 0003-netmdcli-implemented-netmd-download-for-all-supporte.patch
This needs some work, too. It compiles and works fine in plain c but 
compilation fails if these routines are in a c++ class.
I will change this after getting feedback / review and make one new patch.

> This patch currently doesn't apply to git master:
>
> 0001-remove-QtCore-from-the-include-directives-let-qmake-.patch
>
> The best would be to fix the last patch first since it introduces
> changes suggested by Michael.
O.K., i will do that.

> Then, I will go ahead and review the patches for the command line
> utility "netmdcli". And, finally, I will give you feedback on
> the three patches which need additional work.
>
> Thanks for all your hard work!
>
> Adrian
Thomas