Re: [linux-minidisc] Bug: Invalid characters in title strings
On 01/15/2014 07:43 PM, Thomas Arp wrote:
> as reported by a user of the minidiscforum, tracks containing "/"
> character in the title string will fail to upload.
> "/" will be treated as a directory separator, so f.open() will fail
> because of a "missing directory".
>
> I fixed this by removing characters of directory separator type from the
> title string when creating the filename for output.
Thanks for the bug report and the patch! The changes look fine to
me and will be merged.
> This patch can be applied anytime but part #3 of the "netmd download
> support" patch has to be rebased when applying after this patch.
> I prefer applying this patch after all parts of the "netmd download
> support" patch have been committed.
Ok, I agree. I will have to postpone the review of these patches to
the weekend, unfortunately. I am too busy with work.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
