From rene@exactco.de Tue Sep 02 19:21:59 2025 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by list1.zedat.fu-berlin.de (Exim 4.98) for linux-minidisc@lists.fu-berlin.de with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1utUhj-00000001KO6-0wQS; Tue, 02 Sep 2025 19:21:59 +0200 Received: from exactco.de ([176.9.10.151]) by relay1.zedat.fu-berlin.de (Exim 4.98) for linux-minidisc@lists.fu-berlin.de with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1utUhj-00000000ZOo-0YYd; Tue, 02 Sep 2025 19:21:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=exactco.de; s=x; h=Sender:Content-Transfer-Encoding:Content-Type:Mime-Version:From: Subject:Cc:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aWeJa1vGkabpIOq4QN9iknok8zB2coEHENjfFNZUJNc=; b=OY7Rz9uhvF46bXYbOB2fPM6gF1 crGi+J5MIIAEUusVhVFgo0RMJcPXKPftwNvLq4NXo0WM97g3VIsaKgvGEE1MNTYKje+aL4R0dDFvd sfnaFI9nSK3cNxQ8b0tGTmy5/CRbS8NrtR0zm/x5kZf0pp86aKzmH+h+j5GgwDfuCvAv9xuf4ip48 lKc/sZnjncgZoNgNYZhCfM5Q1YkzPjFcrvrHXg7mfNSUDiNmIQQThkQIHF+3kg5spVY1o6Rga6Evi 7mPSkAjycUtXQ7hTN+RAbSv2EppYm7YVpqiJpuxx9Skea+W3iOq/jQFSeKLL4Mk0XK9E0XQwQ9cHQ bdWP4IBA==; Date: Tue, 02 Sep 2025 19:22:00 +0200 (CEST) Message-Id: <20250902.192200.1700867074617091139.rene@exactcode.com> To: linux-minidisc@lists.fu-berlin.de From: Rene Rebe X-Mailer: Mew version 6.10 on Emacs 30.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Sender: rene@exactco.de X-Originating-IP: 176.9.10.151 X-ZEDAT-Hint: I X-purgate: clean X-purgate-type: clean X-purgate-ID: 151147::1756833719-6D810338-7D2A3400/0/0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.053461, version=1.2.4 X-Spam-Flag: NO X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS,SPF_PASS X-Spam-Checker-Version: SpamAssassin 3.4.6 on Vanuatu.ZEDAT.FU-Berlin.DE X-Spam-Level: Subject: [linux-minidisc] [PATCH] NetMD SP Transfer results in audible 'pop' on packet boundary X-BeenThere: linux-minidisc@lists.fu-berlin.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for the linux-minidisc project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2025 17:22:00 -0000 Hi, your emails reminded me that I hit GH#39 this year and wanted to sent you the re-based patch. IIRC the quoated webnetmd code did not apply due to some code changes over the years: Fix audible noise every ~47s, GH#39: NetMD SP Transfer results in audible 'pop' on packet boundary. Tested on Sony MZ-RH1. --- linux-minidisc/libnetmd/secure.c.vanilla 2025-02-22 18:33:21.819516= 328 +0100 +++ linux-minidisc/libnetmd/secure.c 2025-02-22 20:09:42.859406102 +010= 0 @@ -5,6 +5,7 @@ * * Copyright (C) 2004 Bertrik Sikken * Copyright (C) 2011 Alexander Sulfrian + * Copyright (C) 2025 Ren=E9 Rebe * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -485,7 +486,7 @@ gcry_cipher_setkey(data_handle, rand, sizeof(rand)); gcry_cipher_encrypt(data_handle, next->data, chunksize, data += position, packet_data_length); /* set last encrypted block as iv for the next packet */ - memcpy(iv, data + position + packet_data_length - 8, 8); + memcpy(iv, next->data + chunksize - 8, 8); = /* next packet */ position =3D position + chunksize; -- = Ren=E9 Rebe, ExactCODE GmbH, Berlin, Germany https://exactcode.com | https://t2linux.com | https://rene.rebe.de