Re: [Seqan-dev] seqan-dev Digest, Vol 86, Issue 1

[Rahn, René <Rene.Rahn@fu-berlin.de>]

Mhmm, 

mkstemp is a linux system function. Not sure if MinGW ports that. You probably have to use windows API to create a temp directory here. But this is just a guess.

In the function `tempFileName` you probably have to branch into the STDLIB_VS  part if you are using __MINGW32__ to get the windows API running.

cheers,

René

On 12. Mar 2018, at 18:54, August Guang <august.guang@gmail.com> wrote:

Thank you very much for the offer to help.

I have removed the (a)synchronous I/O and also do not define _getOFlag, open and openTemp in <seqan/system/file_sync.h> if __MINGW32__ is the compiler. That solved that error with getuid, getgid, geteuid, getegid.

Now I am getting this error (& 2 warnings):

Error in re-building vignettes:
  ...
                 from file4f341c236111.cpp:4:
D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/mman.h: In function 'void* mmap(void*, size_t, int, int, int, off_t)':
D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/mman.h:111:48: warning: right shift count >= width of type
                     (DWORD)0 : (DWORD)((off >> 32) & 0xFFFFFFFFL);
                                                ^
D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/mman.h:120:52: warning: right shift count >= width of type
                     (DWORD)0 : (DWORD)((maxSize >> 32) & 0xFFFFFFFFL);
                                                    ^
In file included from D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/basic/basic_debug.h:52:0,
                 from D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/basic.h:49,
                 from D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/sequence.h:74,
                 from D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/file.h:67,
                 from file4f341c236111.cpp:4:
D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/basic/debug_test_system.h: In function 'const char* seqan::ClassTest::tempFileName()':
D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include/seqan/basic/debug_test_system.h:712:38: error: 'mkstemp' was not declared in this scope
     int _tmp = mkstemp(fileNameBuffer);
                                      ^
make[1]: *** [file4f341c236111.o] Error 1
make[1]: Entering directory `/cygdrive/d/temp/RtmpIpQdGF/sourceCpp-x86_64-w64-mingw32-0.12.15/sourcecpp_4f34188a2d79'
d:/Compiler/gcc-4.9.3/mingw_64/bin/g++ -m64 -I"D:/RCompile/recent/R/include" -DNDEBUG   -I"D:/temp/RtmpS45h13/RLIBS_2258e843308/Rcpp/include" -I"D:/temp/RtmpS45h13/RLIBS_2258e843308/RSeqAn/include" -I"D:/temp/RtmpIpQdGF/sourceCpp-x86_64-w64-mingw32-0.12.15"   -I"d:/Compiler/gcc-4.9.3/local330/include"  -std=c++14   -pedantic -O2 -Wall  -mtune=core2 -c file4f341c236111.cpp -o file4f341c236111.o
make[1]: Leaving directory `/cygdrive/d/temp/RtmpIpQdGF/sourceCpp-x86_64-w64-mingw32-0.12.15/sourcecpp_4f34188a2d79'

Most of the other errors from the mingw compiler I have been working on have been in this seqan/basic/debug_test_system.h file.

Thanks,

august

On Tue, Mar 6, 2018 at 6:00 AM, <seqan-dev-request@lists.fu-berlin.de> wrote:

Send seqan-dev mailing list submissions to
        seqan-dev@lists.fu-berlin.de

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.fu-berlin.de/listinfo/seqan-dev
or, via email, send a message with subject or body 'help' to
        seqan-dev-request@lists.fu-berlin.de

You can reach the person managing the list at
        seqan-dev-owner@lists.fu-berlin.de

When replying, please edit your Subject line so it is more specific
than "Re: Contents of seqan-dev digest..."


Today's Topics:

   1. Re: placing seqan headers into R package (August Guang)
   2. Re: placing seqan headers into R package (Rahn)


----------------------------------------------------------------------

Message: 1
Date: Mon, 5 Mar 2018 12:01:27 -0500
From: August Guang <august.guang@gmail.com>
To: Hannes Hauswedell <hannes.hauswedell@fu-berlin.de>
Cc: SeqAn Development <seqan-dev@lists.fu-berlin.de>
Subject: Re: [Seqan-dev] placing seqan headers into R package
Message-ID:
        <CAA=4tE_KQ4_u+TwOWRp3ofaKC7nomMKApSJCrCNi3bHbv82vEg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

Thanks, I have included the license file and a notice about citations now.
Will there be support for seqan/2.4 for mingw? I saw that there was on
older versions. The reason I'm asking is that R packages submitted to
Bioconductor/CRAN have to build and pass checks on Linux, OS and Windows,
but on Windows the packages are tested with the mingw compiler and I
haven't found a way around it.

If not, would I be able to get some help with writing support for it? I
have been trying to address various issues specific to mingw but am not
familiar with Windows specific implementations and am getting way out of my
depth. So far I have added mman-win32 to replace sys/mman.h and changed
some enum values to not use posix_madvise. The current error I am trying to
tackle is the fact that getuid, geteuid, getgid and getegid are Unix-only.
It appears I can either write my own macros for them (
https://stackoverflow.com/questions/1594746/win32-equivalent-of-getuid) or
install LibGW32 for them (http://gnuwin32.sourceforge.
net/packages/libgw32c.htm). Is there an option that would be better and can
I get some advice on how I would implement it?

thanks,
august

On Mon, Feb 26, 2018 at 7:49 AM, Hannes Hauswedell <
hannes.hauswedell@fu-berlin.de> wrote:

> Am Donnerstag, 22. Februar 2018, 11:05:38 schrieb August Guang:
> > Hi,
> >
> > I would like to package the SeqAn headers for easy use in a few R
> packages
> > I will be writing with my team, the Computational Biology Core at Brown
> > University in the US. Would this be ok with you all? I am leaving the
> > license as BSD 3 clause as well, and if you would like to make any
> > additions to the license please let me know.
> >
> > You can view the current state of the repository here:
> > https://github.com/compbiocore/RSeqAn
> >
> > Thanks,
> > august
>
> Dear August,
>
> that's great to hear, feel very free to include it in your package. As
> long as
> the LICENSE file is shipped with the package there is no problem. Please
> also
> include a link to www.seqan.de in your documentation and if possible also
> the
> following note:
> "Please do not forget to cite SeqAn if you use this package in your
> acedemic
> work, even if only in auxiliary tools or pipelines:
> https://doi.org/10.1016/j.jbiotec.2017.07.017"
>
> That would be great!
>
> Thank you,
> Hannes
> --
> Hannes Hauswedell
>
> Scientific staff & PhD candidate
> Freie Universit?t Berlin / Max Planck Institute for Molecular Genetics
>
> address     Institut f?r Informatik
>             Takustra?e 9
>             Room 019
>             14195 Berlin
> telephone   +49 (0)30 838-75241
> fax         +49 (0)30 838-75218
> e-mail      hannes.hauswedell@fu-berlin.de
>



--
August Guang

HMC Class of 2012
Mathematics

Brown University
Applied Mathematics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fu-berlin.de/pipermail/seqan-dev/attachments/20180305/227a1105/attachment.html>

------------------------------

Message: 2
Date: Tue, 06 Mar 2018 09:58:14 +0100
From: Rahn, Ren? <Rene.Rahn@fu-berlin.de>
To: SeqAn Development <seqan-dev@lists.fu-berlin.de>
Subject: Re: [Seqan-dev] placing seqan headers into R package
Message-ID: <E2BF2B0D-45A6-493F-B73B-F51FF1DD3904@fu-berlin.de" target="_blank" class="">E2BF2B0D-45A6-493F-B73B-F51FF1DD3904@fu-berlin.de>
Content-Type: text/plain; charset="utf-8"

Hi August,

many thanks for your efforts. I am afraid, that this is actually quite a challenge you are trying here.
We once had support for MinGW, but it caused more problems than bringing any benefit. Hence we removed the support from it, also given by the fact that there was always a free version of Visual Studio available.
Of course, if you are eager to tackle this you will get support from us. But honestly, we need to really check if we can add this into the core library if it will even work.
Please note, that there will be only patch level releases left for the 2.x cycle. So having this MinGW port in a separate repository could be a convenient way for both sides.

We are currently working on SeqAn 3 and this will be no compatible with SeqAn 2 and requires c++17/20. I am afraid this will be a stopper for MinGW for quite some time.
But, I think if Windows comes with a linux subsystem these days it could be worth it to check if R might  package using standard linux on Windows anyway in the future (Not sure if they have it on their wishlist already).

However, we are still happy to assist you to try out minGW compiler. Please let us know the compiler errors you receive, and the invoked build command, so we can have a closer look on our side.
For the respective error you are receiving, it seems the only place that is using it is the <seqan/system/file_sync.h> header and some other headers doing some forward declaration of it.
As far as I am concerned, this is old code and does not really need to be shipped in your project. So you could wrap it into macros, that if MinGW is used these code paths are not evaluated.
We have a virtual stream class now, which is a better alternative for the File class.
Anyhow, I couldn't find any place where we directly use File<Sync|Async> for (a)synchronous I/O so it would be safe to remove for the R port.

Let me know if there is anything more, but please bear in mind, that we are quite busy right now, and it could take a while for us to respond with a proper solution.
Especially in the next two weeks ;)

Best,

Ren?


On 5. Mar 2018, at 18:01, August Guang <august.guang@gmail.com<mailto:august.guang@gmail.com>> wrote:

Thanks, I have included the license file and a notice about citations now. Will there be support for seqan/2.4 for mingw? I saw that there was on older versions. The reason I'm asking is that R packages submitted to Bioconductor/CRAN have to build and pass checks on Linux, OS and Windows, but on Windows the packages are tested with the mingw compiler and I haven't found a way around it.

If not, would I be able to get some help with writing support for it? I have been trying to address various issues specific to mingw but am not familiar with Windows specific implementations and am getting way out of my depth. So far I have added mman-win32 to replace sys/mman.h and changed some enum values to not use posix_madvise. The current error I am trying to tackle is the fact that getuid, geteuid, getgid and getegid are Unix-only. It appears I can either write my own macros for them (https://stackoverflow.com/questions/1594746/win32-equivalent-of-getuid) or install LibGW32 for them (http://gnuwin32.sourceforge.net/packages/libgw32c.htm). Is there an option that would be better and can I get some advice on how I would implement it?

thanks,
august

On Mon, Feb 26, 2018 at 7:49 AM, Hannes Hauswedell <hannes.hauswedell@fu-berlin.de<mailto:hannes.hauswedell@fu-berlin.de>> wrote:
Am Donnerstag, 22. Februar 2018, 11:05:38 schrieb August Guang:
> Hi,
>
> I would like to package the SeqAn headers for easy use in a few R packages
> I will be writing with my team, the Computational Biology Core at Brown
> University in the US. Would this be ok with you all? I am leaving the
> license as BSD 3 clause as well, and if you would like to make any
> additions to the license please let me know.
>
> You can view the current state of the repository here:
> https://github.com/compbiocore/RSeqAn
>
> Thanks,
> august

Dear August,

that's great to hear, feel very free to include it in your package. As long as
the LICENSE file is shipped with the package there is no problem. Please also
include a link to www.seqan.de<http://www.seqan.de/> in your documentation and if possible also the
following note:
"Please do not forget to cite SeqAn if you use this package in your acedemic
work, even if only in auxiliary tools or pipelines:
https://doi.org/10.1016/j.jbiotec.2017.07.017"

That would be great!

Thank you,
Hannes
--
Hannes Hauswedell

Scientific staff & PhD candidate
Freie Universit?t Berlin / Max Planck Institute for Molecular Genetics

address     Institut f?r Informatik
            Takustra?e 9
            Room 019
            14195 Berlin
telephone   +49 (0)30 838-75241<tel:%2B49%20%280%2930%20838-75241>
fax         +49 (0)30 838-75218<tel:%2B49%20%280%2930%20838-75218>
e-mail      hannes.hauswedell@fu-berlin.de<mailto:hannes.hauswedell@fu-berlin.de>



--
August Guang

HMC Class of 2012
Mathematics

Brown University
Applied Mathematics
_______________________________________________
seqan-dev mailing list
seqan-dev@lists.fu-berlin.de<mailto:seqan-dev@lists.fu-berlin.de>
https://lists.fu-berlin.de/listinfo/seqan-dev

---

Ren? Rahn
Ph.D. Student (de.NBI - CIBI)
--------------------------------
Tel:  (+49) 30 838 72974
Mail: rene.rahn@fu-berlin.de<mailto:rene.rahn@fu-berlin.de>
--------------------------------
Institute of Computer Science
Algorithmic Bioinformatics (ABI)
--------------------------------
Freie Universit?t Berlin
Takustra?e 9
14195 Berlin
--------------------------------

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fu-berlin.de/pipermail/seqan-dev/attachments/20180306/22e596ef/attachment.html>

------------------------------

Subject: Digest Footer

_______________________________________________
seqan-dev mailing list
seqan-dev@lists.fu-berlin.de
https://lists.fu-berlin.de/listinfo/seqan-dev


------------------------------

End of seqan-dev Digest, Vol 86, Issue 1
****************************************

--

August Guang

HMC Class of 2012

Mathematics

Brown University

Applied Mathematics

_______________________________________________
seqan-dev mailing list
seqan-dev@lists.fu-berlin.de
https://lists.fu-berlin.de/listinfo/seqan-dev

---

René Rahn

Ph.D. Student (de.NBI - CIBI)

--------------------------------

Tel:  (+49) 30 838 72974

Mail: rene.rahn@fu-berlin.de

--------------------------------

Institute of Computer Science

Algorithmic Bioinformatics (ABI)

--------------------------------

Freie Universität Berlin

Takustraße 9

14195 Berlin

--------------------------------