Re: [linux-minidisc] Patch serie on libusb1.py / usb1.py

[Vincent Pelletier <plr.vincent@gmail.com>]

Hi Adrian,

Le mercredi 27 janvier 2010 23:28:51, Adrian Glaubitz a écrit :
> I'm really amazed by the vast amount of patches you sent in

Please don't look at their content ;) . Many a re stupid typos, codepaths 
never executed and with undefined variables, or fixing stupid comments.
There are actually few patches really adding features, and some are still 
missing or not tested properly.

> and I'm
> really glad that there is coming input from so many people. Great
> work! I will be busy tomorrow but I think I can have a look at the
> patches over the weekend, maybe together with Michael. Do you think
> the patches are safe to be applied to the current NetMD-Python code in
> git-master?

They should not touch any codepath used in current netmd code, so I believe it 
is safe to apply them... But I admit not testing them at all with NetMD-Python 
apps.
I'll test them soon (tomorrow ?) as I have some MDs to transfer to my computer 
(still analogically, though, since I didn't change my MD player).

Also, I finally started a github account[1] for my current USB analyser work, 
and created a tree for just my generic python libusb files (libusb1.py and 
usb1.py). I intent to keep sending patches to your mailing list as I include 
them in github, but if you prefer I can send a "delete lib and add a 
dependency" patch (less work for you, but probably more breakage if I'm not 
careful enough ;) )...
For now I (by default) don't trust github, so I would feel safer with keeping 
a copy on your repository.

[1] http://github.com/vpelletier

Regards,
-- 
Vincent Pelletier