-------- Original-Nachricht -------- > Datum: Wed, 9 Jun 2010 14:48:02 +0200 > Von: Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > An: Thomas Arp <manner.moe@gmx.de> > CC: linux-minidisc@lists.fu-berlin.de > Betreff: Re: [linux-minidisc] creating new directories in file browser > I've tested and reviewed your patch now. Here are my remarks: > > - the patch misses equivalent buttons and entries to create new/remove > folder in menu- and toolbar; having these functions in the context > menus only is unintuitive. I'm not even sure whether context menus > make sense in this context > - the context menus have written the command names in all lower case: > it should read "Remove", not "remove" for example > - the mechanism to create a new folder by abusing a browse directory > (QFileDialog::getExistingDirectory) dialog is a very bad design; > instead it should be possible to create the new folder directly in > the tree view or at least a minimal requester should pop up to ask > for the new folders name (creating a new folder shouldn't be rocket > science ;)) > - the string for this requester is chunked into several pieces: > > ret = QMessageBox::question(this, tr("Removing file ordirectory"), > > > tr("Are you sure you want to remove") + > file + tr(" ?\n\n") + > > tr("Note: The file or directory will be > removed finally ") + > > tr("and cannot be recovered"), > > > > - chunking the message text of this dialog into several pieces will > make translation errorprone and cumbersome; please keep strings to > be tranlated contigous whenever possible > > Adrian O.K., i made some changes now. The patch is not based on the current git(it´s a bit complicated to rebase without internet connection) and icons are missing for the new actions. I just used "+" and "-" instead. Thomas
Attachment:
0001-added-actions-for-creating-directories-and-removing-.patch
Description: Binary data