Re: [linux-minidisc] compiling libnetmd and netmdcli on windows

[John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>]

On Sep 16, 2011, at 5:32 PM, John Paul Adrian Glaubitz wrote:

>>> Before we decide applying the patch, have you actually tested the
>>> changes with real hardware? Are you able to upload and download
>>> tracks on Windows with the changes?
>> Code looks fine. Alas, I won't get around to test on real hardware until
>> monday evening, too. So if there is a positive "does not unexpectedly
>> break" test result, applying that patch is fine.
> 
> OK, I'll test the patch later tonight and will apply it once I have
> confirmed it didn't break anything ;).

I applied the patch and it actually makes the transfers unreliable on my MZ-RH10.

With Thomas' patch:

[glaubitz@z6:linux-minidisc/netmdcli]$ ./netmdcli send LP2.wav
Net MD/Hi-MD
Raw title: 0;Testdisk//1-15;Naoto Ishida// 
Disc Title: Testdisk

No error
No error
No error
No error
No error
No error
No error
netmd_exch_message: netmd_poll failed
Unknown Error
netmd_exch_message: netmd_poll failed
Unknown Error
No error
No error
[glaubitz@z6:linux-minidisc/netmdcli]$ 

Without the patch:

[glaubitz@z6:linux-minidisc/netmdcli]$ ./netmdcli send LP2.wav
Net MD/Hi-MD
Raw title: 0;Testdisk//1-15;Naoto Ishida// 
Disc Title: Testdisk

No error
No error
No error
No error
No error
No error
No error
No error
No error
No error
No error
[glaubitz@z6:linux-minidisc/netmdcli]$ 

Also, with the patch, transfers are not always successful. I attempted 3 transfers
and only one was successful, however the track information was not set.

Track 20 was transferred with the patch applied, Track 21 without the
patch (git master). In both cases, the same audio file was transferred
as downloaded from [1].

Track 20: UnPROT UNKNOWN - 00:53:79 - 
Track 21: UnPROT UNKNOWN - 00:53:79 - test

The reliability problems definitely occur with the patch only. I suppose
it's a timing problem related with the delay changed in the patch
in netmd_poll() in libnetmd/common.c

Why was that changed?

I won't apply the patch unless this is fixed.

Adrian

[1] http://users.physik.fu-berlin.de/~mkarcher/ATRAC/LP2.wav